jenkins-bot has submitted this change and it was merged. Change subject: Switch to var instead of const to work on old NodeJS ......................................................................
Switch to var instead of const to work on old NodeJS I've missed that we still run the old NodeJS version on Jenkins. Change-Id: I823d055a33cf03ce4c1aaa0d0307b7120b134271 --- M lib/collectMetrics.js M lib/cpuTime.js 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Phedenskog: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/collectMetrics.js b/lib/collectMetrics.js index e4b7a37..08335ad 100644 --- a/lib/collectMetrics.js +++ b/lib/collectMetrics.js @@ -7,7 +7,7 @@ 'use strict'; -const cpuTime = require('./cpuTime'); +var cpuTime = require('./cpuTime'); module.exports = { /** diff --git a/lib/cpuTime.js b/lib/cpuTime.js index a01d8d8..c5d225e 100644 --- a/lib/cpuTime.js +++ b/lib/cpuTime.js @@ -13,7 +13,7 @@ // https://github.com/WPO-Foundation/webpagetest/blob/4c64acadc5b1625d5b7526d39452d4c2b97679e6/www/breakdownTimeline.php // jscs:enable -const mapTimings = { +var mapTimings = { EvaluateScript: 'Scripting', "v8.compile": 'Scripting', FunctionCall: 'Scripting', -- To view, visit https://gerrit.wikimedia.org/r/315206 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I823d055a33cf03ce4c1aaa0d0307b7120b134271 Gerrit-PatchSet: 1 Gerrit-Project: performance/WebPageTest Gerrit-Branch: master Gerrit-Owner: Phedenskog <phedens...@wikimedia.org> Gerrit-Reviewer: Phedenskog <phedens...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits