jenkins-bot has submitted this change and it was merged.

Change subject: More const that needs to var in old NodeJS
......................................................................


More const that needs to var in old NodeJS

Lets get this out there so it works again in Jenkins.

Change-Id: Ib97547bcbe44e69fd4d52784d2158af32ea9d9ed
---
M lib/collectMetrics.js
M lib/cpuTime.js
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Phedenskog: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/collectMetrics.js b/lib/collectMetrics.js
index 08335ad..e84216e 100644
--- a/lib/collectMetrics.js
+++ b/lib/collectMetrics.js
@@ -61,12 +61,12 @@
 
                 // you need to turn on timeline collecting and use Chrome for 
this to work
                 if (argv.timeline) {
-                    const cpuTimes = 
cpuTime.sum(wptJson.data.median[view].cpuTimes);
+                    var cpuTimes = 
cpuTime.sum(wptJson.data.median[view].cpuTimes);
                     for (var time of Object.keys(cpuTimes)) {
                         metricsToSend.cpuTimes[keyStart + 'cpuTimes.' + time] =
                         cpuTimes[time];
                     }
-                    const cpuTimesDoc = 
cpuTime.sum(wptJson.data.median[view].cpuTimesDoc);
+                    var cpuTimesDoc = 
cpuTime.sum(wptJson.data.median[view].cpuTimesDoc);
                     for (var cpuTimeDoc of Object.keys(cpuTimesDoc)) {
                         metricsToSend.cpuTimes[keyStart + 'cpuTimesDoc.' + 
cpuTimeDoc] =
                         cpuTimesDoc[cpuTimeDoc];
diff --git a/lib/cpuTime.js b/lib/cpuTime.js
index c5d225e..c59dad0 100644
--- a/lib/cpuTime.js
+++ b/lib/cpuTime.js
@@ -64,7 +64,7 @@
 
 module.exports = {
     sum: function(times) {
-        const total = {};
+        var total = {};
         for (var name of Object.keys(times)) {
             if (mapTimings[name] === undefined) {
                 console.error('Un-mapped entry in devtools timeline metrics:' 
+ name);

-- 
To view, visit https://gerrit.wikimedia.org/r/315209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib97547bcbe44e69fd4d52784d2158af32ea9d9ed
Gerrit-PatchSet: 1
Gerrit-Project: performance/WebPageTest
Gerrit-Branch: master
Gerrit-Owner: Phedenskog <phedens...@wikimedia.org>
Gerrit-Reviewer: Phedenskog <phedens...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to