EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315447
Change subject: Fix logic of MinervaBottomLanguageButton
......................................................................
Fix logic of MinervaBottomLanguageButton
When MinervaBottomLanguageButton is false we should still show
the language button on the main page
Bug: T143829
Change-Id: I7980c7eb046f130420cf1af9d9fbacd3378d6d62
(cherry picked from commit 68a856bb3ab207a4b389854393b1ac944076a442)
---
M includes/skins/SkinMinerva.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/47/315447/1
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 189b639..1194914 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -936,9 +936,11 @@
}
}
- if ( MobileContext::singleton()->getMFConfig()->get(
'MinervaBottomLanguageButton' ) &&
+ if ( $title->isMainPage() && $this->doesPageHaveLanguages || (
+ MobileContext::singleton()->getMFConfig()->get(
'MinervaBottomLanguageButton' ) &&
$this->doesPageHaveLanguages &&
- ( $title->isMainPage() ||
$this->shouldSecondaryActionsIncludeLanguageBtn ) ) {
+ $this->shouldSecondaryActionsIncludeLanguageBtn )
+ ) {
$buttons['language'] = $this->getLanguageButton();
}
--
To view, visit https://gerrit.wikimedia.org/r/315447
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7980c7eb046f130420cf1af9d9fbacd3378d6d62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.28.0-wmf.21
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
