jenkins-bot has submitted this change and it was merged. Change subject: Clean up ApiQueryImageInfo continuation ......................................................................
Clean up ApiQueryImageInfo continuation Reviewing this code, I spotted a few issues: * 'imagerepository' is added to non-images, and to images that were skipped this round due to iicontinue. The latter is particularly troublesome, as clients may wind up with an incorrect value when merging continued results. * Say two images are being queried, A.jpg and B.jpg. If the query needs to be continued somewhere in the middle of A.jpg's old versions, but then A.jpg is deleted before the client sends the continuation query, it will start in the middle of B.jpg's old versions instead of at the beginning of B.jpg's revisions. * If the query needs to be continued somewhere in the middle of A.jpg's old versions, but in the continuation query some other module that is also being continued fills the result object, iicontinue will be reset to the *beginning* of A.jpg's old versions instead of preserving the position in the middle. Change-Id: I08e2941010c7a70ff90b6244bfddd5ed0540fc9f --- M RELEASE-NOTES-1.21 M includes/api/ApiQueryImageInfo.php 2 files changed, 21 insertions(+), 21 deletions(-) Approvals: Anomie: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/47188 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08e2941010c7a70ff90b6244bfddd5ed0540fc9f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: MaxSem <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
