VolkerE has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315456
Change subject: MediaWiki theme: Address subpixel rendering errors in
NumberInputWidget
......................................................................
MediaWiki theme: Address subpixel rendering errors in NumberInputWidget
Adressing subpixel rendering errors in browsers due to `em` to pixel
translation of relative CSS units by specify values that are translating
to full pixels at base `font-size`.
Introducing several Less variables for DRY purposes.
Bug: T102127
Change-Id: I1ecbf767a598704c3913d8853a458f0fe526f5d1
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
M src/themes/mediawiki/widgets.less
3 files changed, 14 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/56/315456/1
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index e620458..6c683cd 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -58,6 +58,7 @@
@max-width-default: 50em;
@max-width-input: @max-width-default;
+@size-button-default: 2.5em; // equals `32px` at base `font-size: 12.8px`
@size-icon-min: 24px;
@size-indicator-min: 12px;
@size-icon: unit( 24 / 16 / 0.8, em );
@@ -87,6 +88,9 @@
@border-width-default: 1px;
@border-width-medium: 2px;
+@padding-widget-default: 0.547em; // equals `6px` at base `font-size: 12.8px`
+@padding-top-input-text: 0.625em; // equals `7px` at base `font-size: 12.8px`
+
@box-shadow-dialog: 0 0.15em 0 0 rgba( 0, 0, 0, 0.15 );
@box-shadow-menu: @box-shadow-dialog;
@box-shadow-focus-default: inset 0 0 0 1px @color-progressive;
diff --git a/src/themes/mediawiki/elements.less
b/src/themes/mediawiki/elements.less
index 52c4b3e..fbf46a9 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -164,8 +164,8 @@
}
> .oo-ui-buttonElement-button {
- padding: 0.5em 1em;
- min-height: 1.2em;
+ padding: @padding-widget-default 1em;
+ min-height: 1.25em;
min-width: 1em;
border-radius: @border-radius-default;
position: relative;
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 1ac7c08..1db4f31 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -701,7 +701,6 @@
input,
textarea {
- padding: 0.5em;
margin: 0;
font-size: inherit;
font-family: inherit;
@@ -709,6 +708,11 @@
color: @color-emphasized;
border: @border-default;
border-radius: @border-radius-default;
+ padding: @padding-top-input-text @padding-widget-default
@padding-widget-default;
+ }
+
+ input {
+ line-height: 1.172em; // Firefox needs a value, Chrome the
unit; equals `15px` at base `font-size: 12.8px`
}
textarea {
@@ -868,7 +872,7 @@
}
&-dropdownButton {
- width: 2.5em;
+ width: @size-button-default;
.oo-ui-buttonElement-button {
padding: 0.5em;
@@ -1449,11 +1453,12 @@
&-buttoned {
.oo-ui-buttonWidget {
- width: 2.5em;
+ width: @size-button-default;
}
.oo-ui-buttonElement-button {
display: block;
+ min-height: @size-button-default;
padding-left: 0;
padding-right: 0;
}
--
To view, visit https://gerrit.wikimedia.org/r/315456
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ecbf767a598704c3913d8853a458f0fe526f5d1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
