Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315476

Change subject: [WIP] Refactor timeline browsertests
......................................................................

[WIP] Refactor timeline browsertests

- Applied the Given-When-Then rule

Bug: T146276
Change-Id: I0278ef607f96851ed69e7373b952f5d02139cb0c
---
M tests/browser/features/timeline.feature
1 file changed, 4 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/76/315476/1

diff --git a/tests/browser/features/timeline.feature 
b/tests/browser/features/timeline.feature
index 94df85b..16f8f9a 100644
--- a/tests/browser/features/timeline.feature
+++ b/tests/browser/features/timeline.feature
@@ -8,9 +8,7 @@
   Scenario: RevisionSlider timeline arrows to be disabled with 3 revisions
     Given a page with 3 revision(s) exists
     And I am on the diff page
-    And I click on the expand button
-    And The RevisionSlider has loaded
-    And I have dismissed the help dialog
+    When I have loaded the RevisionSlider and dismissed the help dialog
     Then The backward arrow should be disabled
     And The forward arrow should be disabled
 
@@ -18,15 +16,8 @@
     Given a page with 30 revision(s) exists
     And The window size is 800 by 600
     And I am on the diff page
-    And I click on the expand button
-    And The RevisionSlider has loaded
-    And I have dismissed the help dialog
-    And The help dialog is hidden
+    When I have loaded the RevisionSlider and dismissed the help dialog
+    And I click on the backward arrow
+    And I click on the forward arrow
     Then The backward arrow should be enabled
     And The forward arrow should be disabled
-    Given I click on the backward arrow
-    Then The backward arrow should be disabled
-    And The forward arrow should be enabled
-    Given I click on the forward arrow
-    Then The backward arrow should be enabled
-    And The forward arrow should be disabled
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/315476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0278ef607f96851ed69e7373b952f5d02139cb0c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to