Matmarex has uploaded a new change for review. Change subject: made the footer cleanup script suck less ......................................................................
made the footer cleanup script suck less Rewrote it to make it a little more readable and discovered a couple of bugs in the process. Fixes: * The list slid up on initial collapsing and just toggled on click. This was clearly backwards; now it acts the other way. * The function silently failed when invalid arguments were passed. Now it throws instead. * The footerCollapsibleList function accepted a <ul> as its argument and then thrashed about, adding and removing elements within its container. Now it accepts the container itself. Change-Id: I4ceea2242a977379ca724b8a4fee6f3d2bc0fd24 --- M modules/ext.vector.footerCleanup.js M modules/jquery.footerCollapsibleList.js 2 files changed, 40 insertions(+), 39 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Vector refs/changes/33/48033/1 -- To view, visit https://gerrit.wikimedia.org/r/48033 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ceea2242a977379ca724b8a4fee6f3d2bc0fd24 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Vector Gerrit-Branch: master Gerrit-Owner: Matmarex <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
