Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315492

Change subject: Some doc-block changes
......................................................................

Some doc-block changes

Change-Id: Ie891e412d2839edeb5ad5e6ef21e0510ec5e788b
---
M src/ScopedCallback.php
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/libs/ScopedCallback 
refs/changes/92/315492/2

diff --git a/src/ScopedCallback.php b/src/ScopedCallback.php
index 0a685c8..16d475e 100644
--- a/src/ScopedCallback.php
+++ b/src/ScopedCallback.php
@@ -25,7 +25,7 @@
 namespace Wikimedia;
 
 /**
- * Class for asserting that a callback happens when an dummy object leaves 
scope
+ * Class for asserting that a callback happens when a dummy object leaves scope
  */
 class ScopedCallback {
        /** @var callable */
@@ -35,7 +35,7 @@
 
        /**
         * @param callable|null $callback
-        * @param array $params Callback arguments (since 1.25)
+        * @param array $params Callback arguments (since 1.0.0, MediaWiki 1.25)
         * @throws \InvalidArgumentException
         */
        public function __construct( $callback, array $params = [] ) {
@@ -48,7 +48,7 @@
 
        /**
         * Trigger a scoped callback and destroy it.
-        * This is the same is just setting it to null.
+        * This is the same as just setting it to null.
         *
         * @param ScopedCallback $sc
         */
@@ -57,7 +57,7 @@
        }
 
        /**
-        * Destroy a scoped callback without triggering it
+        * Destroy a scoped callback without triggering it.
         *
         * @param ScopedCallback $sc
         */
@@ -69,7 +69,7 @@
        }
 
        /**
-        * Trigger the callback when this leaves scope
+        * Trigger the callback when it leaves scope.
         */
        function __destruct() {
                if ( $this->callback !== null ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/315492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie891e412d2839edeb5ad5e6ef21e0510ec5e788b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/libs/ScopedCallback
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to