Filippo Giunchedi has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315494

Change subject: thumbor: require only instance_service_path
......................................................................

thumbor: require only instance_service_path

Causes a catalog compilation failure:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER:
Invalid relationship: Service[thumbor@8801] { require =>
File[/srv/thumbor/tmp/thumbor@8801] }, because
File[/srv/thumbor/tmp/thumbor@8801] doesn't seem to be in the catalog
Warning: Not using cache on failed catalog

Also the related exec has before => Service already.

Change-Id: Iecd51b7b11dca8fb3303039e91166937801543dc
---
M modules/thumbor/manifests/instance.pp
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/94/315494/1

diff --git a/modules/thumbor/manifests/instance.pp 
b/modules/thumbor/manifests/instance.pp
index 0fb82a9..3f72318 100644
--- a/modules/thumbor/manifests/instance.pp
+++ b/modules/thumbor/manifests/instance.pp
@@ -37,10 +37,7 @@
         ensure   => running,
         provider => 'systemd',
         enable   => true,
-        require  => File[
-            $instance_service_path,
-            "/srv/thumbor/tmp/thumbor@${port}"
-        ],
+        require  => File[$instance_service_path],
     }
 
     nrpe::monitor_systemd_unit_state{ "thumbor@${port}":

-- 
To view, visit https://gerrit.wikimedia.org/r/315494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecd51b7b11dca8fb3303039e91166937801543dc
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to