Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315541

Change subject: Load skins.minerva.icons.images.variants in stable
......................................................................

Load skins.minerva.icons.images.variants in stable

* Chevrons uses to toggle sections and in footer are now loaded
at load rather than via JS
*  Talk icon now shows in stable

Downsides:
* Additional bloat in initial CSS load: each icon has 2 variants so
this adds css for 6 icons to page load

Bug: T142976
Change-Id: Ic325f58864fef8fc8e7de14d3c6aca4f89af9dce
---
M includes/skins/SkinMinerva.php
M includes/skins/SkinMinervaBeta.php
2 files changed, 1 insertion(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/41/315541/1

diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 757225a..a406a64 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -1264,6 +1264,7 @@
                        'mediawiki.ui.icon',
                        'mediawiki.ui.button',
                        'skins.minerva.icons.images',
+                       'skins.minerva.icons.images.variants',
                ];
                if ( $title->isMainPage() ) {
                        $styles[] = 'skins.minerva.mainPage.styles';
diff --git a/includes/skins/SkinMinervaBeta.php 
b/includes/skins/SkinMinervaBeta.php
index 2df1af8..1c1da67 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -47,16 +47,4 @@
 
                return $modules;
        }
-
-       /**
-        * Get the needed styles for this skin
-        * @return array
-        */
-       protected function getSkinStyles() {
-               $title = $this->getTitle();
-               $styles = parent::getSkinStyles();
-               $styles[] = 'skins.minerva.icons.images.variants';
-
-               return $styles;
-       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/315541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic325f58864fef8fc8e7de14d3c6aca4f89af9dce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to