jenkins-bot has submitted this change and it was merged. Change subject: Fixed typeError when TBar buttons are removed by subclass ......................................................................
Fixed typeError when TBar buttons are removed by subclass Change-Id: I0a5b6023976da9d7e17361156382eb02e15042b7 --- M resources/bluespice.extjs/BS/CRUDGridPanel.js 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Robert Vogel: Looks good to me, approved Pwirth: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/resources/bluespice.extjs/BS/CRUDGridPanel.js b/resources/bluespice.extjs/BS/CRUDGridPanel.js index 2942a27..40bd6e8 100644 --- a/resources/bluespice.extjs/BS/CRUDGridPanel.js +++ b/resources/bluespice.extjs/BS/CRUDGridPanel.js @@ -193,12 +193,18 @@ }, onGrdMainRowClick: function( oSender, iRowIndex, oEvent ) { - this.btnEdit.enable(); - this.btnRemove.enable(); + if( this.btnEdit ) { + this.btnEdit.enable(); + } + if( this.btnRemove ) { + this.btnRemove.enable(); + } var selectedRecords = this.grdMain.getSelectionModel().getSelection(); if( selectedRecords.length > 1 ) { - this.btnEdit.disable(); + if( this.btnEdit ) { + this.btnEdit.disable(); + } } }, onStrMainLoadBase: function() { -- To view, visit https://gerrit.wikimedia.org/r/315484 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a5b6023976da9d7e17361156382eb02e15042b7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation Gerrit-Branch: master Gerrit-Owner: Gerharddiller85 <gerhard.dil...@hotmail.com> Gerrit-Reviewer: Dvogel hallowelt <daniel.vo...@hallowelt.com> Gerrit-Reviewer: Ljonka <l.verhovs...@gmail.com> Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz> Gerrit-Reviewer: Pwirth <wi...@hallowelt.biz> Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits