Jonas Kress (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315655
Change subject: Add title attribute to rank and value selection menu item
......................................................................
Add title attribute to rank and value selection menu item
Bug: T139357
Change-Id: Ia64c51d7bced7ddd1ed6d51b13d5db183f9cb9aa
---
M repo/i18n/en.json
M repo/i18n/qqq.json
M view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
M view/resources/jquery/wikibase/resources.php
4 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/55/315655/1
diff --git a/repo/i18n/en.json b/repo/i18n/en.json
index ffc0e8f..177580b 100644
--- a/repo/i18n/en.json
+++ b/repo/i18n/en.json
@@ -91,8 +91,11 @@
"wikibase-claimview-snak-tooltip": "Enter a value corresponding to the
property named \"$1\". If the property has no designated value or the actual
value is not known, you can choose an alternative value type by clicking the
icon before the input box.",
"wikibase-claimview-snak-new-tooltip": "After specifying a property you
can enter a corresponding value. If the property has no designated value or the
actual value is not known, you can choose an alternative value type by clicking
the icon before the input box.",
"wikibase-statementview-rank-preferred": "Preferred rank",
+ "wikibase-statementview-rank-tooltip-preferred": "Valid and up-to-date
value",
"wikibase-statementview-rank-normal": "Normal rank",
+ "wikibase-statementview-rank-tooltip-normal": "Valid value, though
possibly historic",
"wikibase-statementview-rank-deprecated": "Deprecated rank",
+ "wikibase-statementview-rank-tooltip-deprecated": "Value is known to be
wrong but (used to be) commonly believed",
"wikibase-statementview-references-counter":
"$1{{PLURAL:$2|0=|$3+$2$4}} {{PLURAL:$1|reference|references}}",
"wikibase-statementview-referencesheading-pendingcountertooltip":
"{{PLURAL:$1|One reference|$1 references}} not saved yet",
"wikibase-snakview-property-input-placeholder": "property",
diff --git a/repo/i18n/qqq.json b/repo/i18n/qqq.json
index 1493122..2e4151b 100644
--- a/repo/i18n/qqq.json
+++ b/repo/i18n/qqq.json
@@ -122,8 +122,11 @@
"wikibase-claimview-snak-tooltip": "Tooltip message displayed when
hovering/clicking the help icon next to the save, cancel and remove links of a
claim (see [[d:Wikidata:Glossary#Claim]]).\n\nParameters:\n* $1 - the property
name the user is about to edit a value of or add another value to",
"wikibase-claimview-snak-new-tooltip": "Tooltip message displayed when
hovering/clicking the help icon next to the save, cancel and remove links of a
claim (see [[d:Wikidata:Glossary]]) when about to add a completely new claim
which includes specifying the property.",
"wikibase-statementview-rank-preferred": "Label of the
[[d:Wikidata:Glossary#Rank-preferred|Preferred Rank]] item within the menu that
allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]]
[[d:Wikidata:Glossary#Rank|Rank]]. The message is additionally used as tooltip
on the rank icon when the statement has assigned the Preferred rank.",
+ "wikibase-statementview-rank-tooltip-preferred": "Tooltip of the
[[d:Wikidata:Glossary#Rank-preferred|Preferred Rank]] item within the menu that
allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]]
[[d:Wikidata:Glossary#Rank|Rank]].",
"wikibase-statementview-rank-normal": "Label of the
[[d:Wikidata:Glossary#Rank-normal|Normal Rank]] item within the menu that
allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]]
[[d:Wikidata:Glossary#Rank|Rank]]. The message is additionally used as tooltip
on the rank icon when the statement has assigned the Normal Rank.",
+ "wikibase-statementview-rank-tooltip-normal": "Tooltip of the
[[d:Wikidata:Glossary#Rank-normal|Normal Rank]] item within the menu that
allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]]
[[d:Wikidata:Glossary#Rank|Rank]].",
"wikibase-statementview-rank-deprecated": "Label of the
[[d:Wikidata:Glossary#Rank-deprecated|Deprecated Rank]] item within the menu
that allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]]
[[d:Wikidata:Glossary#Rank|Rank]]. The message is additionally used as tooltip
on the rank icon when the statement has assigned the Deprecated Rank.",
+ "wikibase-statementview-rank-tooltip-deprecated": "Tooltip of the
[[d:Wikidata:Glossary#Rank-deprecated|Deprecated Rank]] item within the menu
that allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]]
[[d:Wikidata:Glossary#Rank|Rank]].",
"wikibase-statementview-references-counter": "Used in the heading for
the references associated with a statement (see [[d:Wikidata:Glossary]]). The
heading is giving information about how many references exist for that
statement. This is the whole heading. The number of unsaved references should
only be displayed if it's not zero. In that case, it is wrapped by $3 and $4 to
add an HTML tooltip.\n\nParameters:\n* $1 - the number of saved references\n*
$2 - the number of unsaved references\n* $3 - placeholder for HTML wrapping the
number of unsaved references, if displayed (beginning)\n* $4 - placeholder for
HTML wrapping the number of unsaved references, if displayed
(end)\n{{Identical|Reference}}",
"wikibase-statementview-referencesheading-pendingcountertooltip":
"Tooltip displayed in the references heading when there are references (see
[[d:Wikidata:Glossary]]) in edit mode which are not saved
yet.\n\nParameters:\n* $1 - the number of elements not saved yet",
"wikibase-snakview-property-input-placeholder": "Placeholder message
that is initially displayed within the property input element when adding a new
snak. See also [[d:Wikidata:Glossary]].\n{{Identical|Property}}",
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
index 79cb7a0..29ab036 100644
---
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
+++
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
@@ -208,6 +208,7 @@
.append(
$( '<a/>' )
.text( mw.msg(
'wikibase-statementview-rank-' + rankName ) )
+ .attr( 'title', mw.msg(
'wikibase-statementview-rank-tooltip-' + rankName ) )
.on( 'click.' +
self.widgetName, function( event ) {
event.preventDefault();
} )
diff --git a/view/resources/jquery/wikibase/resources.php
b/view/resources/jquery/wikibase/resources.php
index d3c1a46..2c70db8 100644
--- a/view/resources/jquery/wikibase/resources.php
+++ b/view/resources/jquery/wikibase/resources.php
@@ -418,8 +418,11 @@
'wikibase-claimview-snak-tooltip',
'wikibase-claimview-snak-new-tooltip',
'wikibase-statementview-rank-preferred',
+ 'wikibase-statementview-rank-tooltip-preferred',
'wikibase-statementview-rank-normal',
+ 'wikibase-statementview-rank-tooltip-normal',
'wikibase-statementview-rank-deprecated',
+
'wikibase-statementview-rank-tooltip-deprecated',
'wikibase-statementview-references-counter',
'wikibase-statementview-referencesheading-pendingcountertooltip',
),
--
To view, visit https://gerrit.wikimedia.org/r/315655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia64c51d7bced7ddd1ed6d51b13d5db183f9cb9aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
