Andrew Bogott has submitted this change and it was merged.

Change subject: puppet: Add a message announcing deprecation to 
role::puppet::self
......................................................................


puppet: Add a message announcing deprecation to role::puppet::self

Bug: T120159
Change-Id: I2ed6b291b6c826a96f9831bad26ad9fc11f2251c
---
M modules/role/manifests/puppet/self.pp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/role/manifests/puppet/self.pp 
b/modules/role/manifests/puppet/self.pp
index f5ac3c6..5a42061 100644
--- a/modules/role/manifests/puppet/self.pp
+++ b/modules/role/manifests/puppet/self.pp
@@ -13,6 +13,9 @@
     $master = $::puppetmaster,
     $autoupdate_master = true,
 ) {
+    # Deprecate!
+    $message = 'Please do not use this role on new instances! Use 
https://wikitech.wikimedia.org/wiki/Standalone_puppetmaster instead'
+    notify { $message: }
     if $master != undef {
         if $master =~ /\./ {
             fail("${::puppetmaster} must be a simple hostname.  The 
project-specific domain will be automatically appended.")

-- 
To view, visit https://gerrit.wikimedia.org/r/315564
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ed6b291b6c826a96f9831bad26ad9fc11f2251c
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <yuvipa...@wikimedia.org>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to