jenkins-bot has submitted this change and it was merged.

Change subject: Refactor tooltips browsertests
......................................................................


Refactor tooltips browsertests

- Applied the Given-When-Then rule

Bug: T146276
Change-Id: Ie9eb48cafd85ef7a00c9d9f9fd626fab5f128824
---
M tests/browser/features/tooltips.feature
1 file changed, 10 insertions(+), 12 deletions(-)

Approvals:
  WMDE-Fisch: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/browser/features/tooltips.feature 
b/tests/browser/features/tooltips.feature
index a7491a4..b35e394 100644
--- a/tests/browser/features/tooltips.feature
+++ b/tests/browser/features/tooltips.feature
@@ -5,23 +5,21 @@
     And I have reset my preferences
     And RevisionSlider is enabled as a beta feature
     And a page with 4 revision(s) exists
-    And I am on the diff page
-    And I click on the expand button
-    And The RevisionSlider has loaded
-    And I have dismissed the help dialog
 
   Scenario: RevisionSlider revision tooltip appears on hover
-    Given I hover over revision 1
-    Then a tooltip should be present for revision 1
-    Given I hover over revision 2
+    Given I am on the diff page
+    When I have loaded the RevisionSlider and dismissed the help dialog
+    And I hover over revision 1
+    And I hover over revision 2
     Then a tooltip should be present for revision 2
     And no tooltip should be present for revision 1
 
   Scenario: RevisionSlider revision tooltip appears and remains on hover
-    Given I hover over revision 1
-    Then a tooltip should be present for revision 1
-    Given I hover over the revision 1 tooltip
-    Then a tooltip should be present for revision 1
-    Given I hover over revision 2
+    Given I am on the diff page
+    When I have loaded the RevisionSlider and dismissed the help dialog
+    And I hover over revision 1
+    And I hover over the revision 1 tooltip
+    And I hover over revision 2
+    And I hover over the revision 2 tooltip
     Then a tooltip should be present for revision 2
     And no tooltip should be present for revision 1
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/315509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9eb48cafd85ef7a00c9d9f9fd626fab5f128824
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to