Kaldari has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315881

Change subject: Update assessments from any talk pages, not just NS_TALK pages
......................................................................

Update assessments from any talk pages, not just NS_TALK pages

Assessments may be recorded on other talk pages besides NS_TALK pages,
for example, NS_CATEGORY_TALK.

Change-Id: I65f086b31a17bb047b7aac8e30dae5ff05289110
---
M PageAssessments.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments 
refs/changes/81/315881/1

diff --git a/PageAssessments.hooks.php b/PageAssessments.hooks.php
index b9aec25..8129e1a 100644
--- a/PageAssessments.hooks.php
+++ b/PageAssessments.hooks.php
@@ -38,8 +38,8 @@
        public static function onLinksUpdateComplete( &$linksUpdate, $ticket = 
null ) {
                $title = $linksUpdate->getTitle();
                // This assumes that the assessment parser function is only 
used on talk pages.
-               // See T147906 for why assessments are not supported in either 
namespace.
-               if ( $title->getNamespace() === NS_TALK ) {
+               // See T147906 for why assessments are not supported on subject 
pages.
+               if ( $title->isTalkPage() ) {
                        $pOut = $linksUpdate->getParserOutput();
                        if ( $pOut->getExtensionData( 
'ext-pageassessment-assessmentdata' ) !== null ) {
                                $assessmentData = $pOut->getExtensionData( 
'ext-pageassessment-assessmentdata' );

-- 
To view, visit https://gerrit.wikimedia.org/r/315881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65f086b31a17bb047b7aac8e30dae5ff05289110
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Kaldari <rkald...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to