jenkins-bot has submitted this change and it was merged. Change subject: Update linters and remove redundant ones ......................................................................
Update linters and remove redundant ones eslint covers jshint and jscs rules. Change-Id: Ieff7a050021e504575a774c7c9ba987b23380294 --- D .csslintrc M Gruntfile.js M package.json 3 files changed, 4 insertions(+), 34 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, approved jenkins-bot: Verified diff --git a/.csslintrc b/.csslintrc deleted file mode 100644 index ec188a9..0000000 --- a/.csslintrc +++ /dev/null @@ -1,13 +0,0 @@ -{ - "adjoining-classes": false, - "box-model": false, - "box-sizing": false, - "fallback-colors": false, - "ids": false, - "important": false, - "outline-none": false, - "overqualified-elements": false, - "qualified-headings": false, - "universal-selector": false, - "unqualified-attributes": false -} diff --git a/Gruntfile.js b/Gruntfile.js index 10f2ac6..05a2d46 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -1,9 +1,7 @@ /* jshint node:true */ module.exports = function ( grunt ) { grunt.loadNpmTasks( 'grunt-banana-checker' ); - grunt.loadNpmTasks( 'grunt-contrib-jshint' ); grunt.loadNpmTasks( 'grunt-eslint' ); - grunt.loadNpmTasks( 'grunt-jscs' ); grunt.loadNpmTasks( 'grunt-jsonlint' ); grunt.loadNpmTasks( 'grunt-stylelint' ); @@ -14,19 +12,6 @@ 'tests/**/*.js', 'modules/**/*.js' ] - }, - jshint: { - options: { - jshintrc: true - }, - all: [ - '*.js', - 'tests/**/*.js', - 'modules/**/*.js' - ] - }, - jscs: { - src: '<%= jshint.all %>' }, stylelint: { all: [ @@ -46,6 +31,6 @@ } } ); - grunt.registerTask( 'test', [ 'eslint', 'jshint', 'jscs', 'jsonlint', 'stylelint', 'banana' ] ); + grunt.registerTask( 'test', [ 'eslint', 'jsonlint', 'stylelint', 'banana' ] ); grunt.registerTask( 'default', 'test' ); }; diff --git a/package.json b/package.json index 8bd5cf4..8facbfe 100644 --- a/package.json +++ b/package.json @@ -14,11 +14,9 @@ "eslint-config-wikimedia": "0.1.0", "grunt": "1.0.1", "grunt-banana-checker": "0.5.0", - "grunt-contrib-jshint": "1.0.0", "grunt-eslint": "19.0.0", - "grunt-jscs": "3.0.0", - "grunt-jsonlint": "1.0.8", - "grunt-stylelint": "0.4.0", - "stylelint-config-wikimedia": "0.2.2" + "grunt-jsonlint": "1.1.0", + "grunt-stylelint": "0.6.0", + "stylelint-config-wikimedia": "0.3.0" } } \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/315737 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieff7a050021e504575a774c7c9ba987b23380294 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/RevisionSlider Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits