Mobrovac has submitted this change and it was merged.

Change subject: Removed deprecated rule about page image
......................................................................


Removed deprecated rule about page image

Bug: T147516
Change-Id: I2c1b81b2fa256cce671d0121c249e79c9c5daa07
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 22 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index fd6a321..002ac37 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -586,46 +586,26 @@
                             redirect: false
 
                     # Rerender summary when pageimages page property change
-                    # This is a temporary workaround until we get a complete 
page properties change event.
                     page_images:
-                      topic: resource_change
-                      match:
-                        meta:
-                          uri: '/^https?:\/\/[^\/]+\/wiki\/(?<title>.+)$/'
-                        tags:
-                          - page_image
-                      exec:
-                        method: get
-                        uri: '<%= restbase_uri 
%>/{{message.meta.domain}}/v1/page/summary/{{match.meta.uri.title}}'
-                        headers:
-                          cache-control: no-cache
-                        query:
-                          redirect: false
-                    # the rule replacing the one above, to be phased out
-                    page_images_change:
                       topic: mediawiki.page-properties-change
                       # We don't support 'OR' in the match section, so 
workaround it by 2 cases with identical exec
                       cases:
                         - match:
-                            meta:
-                              uri: '/^https?:\/\/[^\/]+\/wiki\/(?<title>.+)$/'
                             added_properties:
                               page_image: '/.+/' # Regex that matches anything 
just to check the prop is set
                           exec:
                             method: get
-                            uri: '<%= restbase_uri 
%>/{{message.meta.domain}}/v1/page/summary/{{match.meta.uri.title}}'
+                            uri: '<%= restbase_uri 
%>/{{message.meta.domain}}/v1/page/summary/{message.page_title}'
                             headers:
                               cache-control: no-cache
                             query:
                               redirect: false
                         - match:
-                            meta:
-                              uri: '/^https?:\/\/[^\/]+\/wiki\/(?<title>.+)$/'
                             removed_properties:
                               page_image: '/.+/' # Regex that matches anything 
just to check the prop is set
                           exec:
                             method: get
-                            uri: '<%= restbase_uri 
%>/{{message.meta.domain}}/v1/page/summary/{{match.meta.uri.title}}'
+                            uri: '<%= restbase_uri 
%>/{{message.meta.domain}}/v1/page/summary/{message.page_title}'
                             headers:
                               cache-control: no-cache
                             query:

-- 
To view, visit https://gerrit.wikimedia.org/r/315744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2c1b81b2fa256cce671d0121c249e79c9c5daa07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to