WikidataBuilder has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315922

Change subject: New Wikidata Build - 2016-10-14T10:00:01+0000
......................................................................

New Wikidata Build - 2016-10-14T10:00:01+0000

Change-Id: Idaa3ee8dcc70669b56e04b038ac69c80c41ec5b0
---
M composer.lock
M extensions/Wikibase/client/i18n/vro.json
M extensions/Wikibase/client/i18n/zh-hant.json
M extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php
M 
extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
M extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
M extensions/Wikibase/lib/tests/phpunit/Store/EntityInfoBuilderTest.php
M extensions/Wikibase/repo/i18n/de.json
M extensions/Wikibase/repo/i18n/en.json
M extensions/Wikibase/repo/i18n/pt.json
M extensions/Wikibase/repo/i18n/qqq.json
M 
extensions/Wikibase/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
M extensions/Wikibase/view/resources/jquery/wikibase/resources.php
M vendor/composer/installed.json
14 files changed, 197 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/22/315922/1

diff --git a/composer.lock b/composer.lock
index 9cadb17..721a0db 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1574,12 +1574,12 @@
             "source": {
                 "type": "git",
                 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
-                "reference": "7f7a926567984089c1c157da35f19260d18bd7c9"
+                "reference": "f565a7192b96d565677eb6f8661417b574d2eb80"
             },
             "dist": {
                 "type": "zip",
-                "url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/7f7a926567984089c1c157da35f19260d18bd7c9";,
-                "reference": "7f7a926567984089c1c157da35f19260d18bd7c9",
+                "url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/f565a7192b96d565677eb6f8661417b574d2eb80";,
+                "reference": "f565a7192b96d565677eb6f8661417b574d2eb80",
                 "shasum": ""
             },
             "require": {
@@ -1653,7 +1653,7 @@
                 "wikibaserepo",
                 "wikidata"
             ],
-            "time": "2016-10-13 08:27:02"
+            "time": "2016-10-13 20:55:34"
         },
         {
             "name": "wikibase/wikimedia-badges",
diff --git a/extensions/Wikibase/client/i18n/vro.json 
b/extensions/Wikibase/client/i18n/vro.json
index b12557f..9a8af1c 100644
--- a/extensions/Wikibase/client/i18n/vro.json
+++ b/extensions/Wikibase/client/i18n/vro.json
@@ -14,5 +14,5 @@
        "wikibase-rc-hide-wikidata-show": "Näütäq",
        "wikibase-rc-wikibase-edit-letter": "A",
        "wikibase-rc-wikibase-edit-title": "Ütsüse {{WBREPONAME}} muutminõ",
-       "wikibase-otherprojects": "Teisin projekten"
+       "wikibase-otherprojects": "Tõisin projekten"
 }
diff --git a/extensions/Wikibase/client/i18n/zh-hant.json 
b/extensions/Wikibase/client/i18n/zh-hant.json
index fa2f2da..aa424bc 100644
--- a/extensions/Wikibase/client/i18n/zh-hant.json
+++ b/extensions/Wikibase/client/i18n/zh-hant.json
@@ -16,7 +16,8 @@
                        "MoonYaksha",
                        "EagerLin",
                        "一個正常人",
-                       "Cwek"
+                       "Cwek",
+                       "1233thehongkonger"
                ]
        },
        "wikibase-client-desc": "Wikibase 擴充套件客戶端",
@@ -73,6 +74,7 @@
        "wikibase-pageswithbadges-invalid-id": "“$1” 不是一個有效 ID 項目",
        "wikibase-pageswithbadges-badge": "徽章:",
        "wikibase-pageswithbadges-submit": "顯示頁面",
+       "wikibase-entityusage-invalid-id": "“$1” 不是一個有效的實體",
        "wikibase-pageinfo-entity-id": "{{WBREPONAME}} 項目 ID",
        "wikibase-pageinfo-entity-id-none": "無",
        "wikibase-property-render-error": "顯示屬性 $1:$2 失敗",
diff --git 
a/extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php 
b/extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php
index 0820dec..7451b5f 100644
--- a/extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php
+++ b/extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php
@@ -53,7 +53,8 @@
         * @param string $subPage
         */
        public function execute( $subPage ) {
-               $this->prepareParams( $subPage );
+               $entity = $this->getRequest()->getText( 'entity', $subPage );
+               $this->prepareParams( $entity );
 
                if ( $this->entityId !== null ) {
                        parent::execute( $subPage );
@@ -65,11 +66,9 @@
        }
 
        /**
-        * @param string $subPage
+        * @param string $entity
         */
-       private function prepareParams( $subPage ) {
-               $entity = $this->getRequest()->getText( 'entity', $subPage );
-
+       public function prepareParams( $entity ) {
                if ( $entity ) {
                        try {
                                $this->entityId = $this->idParser->parse( 
$entity );
@@ -128,9 +127,11 @@
        public function getQueryInfo() {
                $joinConds = [ 'wbc_entity_usage' => [ 'JOIN', [ 'page_id = 
eu_page_id' ] ] ];
                $conds = [ 'eu_entity_id' => 
$this->entityId->getSerialization() ];
-               $groupConcat = wfGetDB( DB_REPLICA )
-                       ->buildGroupConcatField( '|', 'wbc_entity_usage',
-                               'eu_aspect', $conds, $joinConds
+               $groupConcat = wfGetDB( DB_REPLICA )->buildGroupConcatField(
+                       '|',
+                       'wbc_entity_usage',
+                       'eu_aspect',
+                       [ 'eu_page_id = page_id' ] + $conds
                );
 
                return [
diff --git 
a/extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
 
b/extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
index e3daa05..794289e 100644
--- 
a/extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
+++ 
b/extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
@@ -6,7 +6,9 @@
 use RequestContext;
 use SpecialPageFactory;
 use SpecialPageTestBase;
+use Title;
 use Wikibase\Client\Specials\SpecialEntityUsage;
+use WikiPage;
 
 /**
  * @covers Wikibase\Client\Specials\SpecialEntityUsage
@@ -27,10 +29,18 @@
                                'value' => 11,
                                'namespace' => 0,
                                'title' => 'Tehran',
-                               'aspects' => 'S|O|L.fa',
+                               'aspects' => 'O|L.fa',
                                'eu_page_id' => 11,
                                'eu_entity_id' => 'Q3',
                        ],
+                       (object)[
+                               'value' => 22,
+                               'namespace' => 0,
+                               'title' => 'Athena',
+                               'aspects' => 'S',
+                               'eu_page_id' => 22,
+                               'eu_entity_id' => 'Q3',
+                       ]
                ];
 
                return new FakeResultWrapper( $rows );
@@ -53,18 +63,25 @@
 
        public function testExecuteWithValidParam() {
                list( $result, ) = $this->executeSpecialPage( 'Q3' );
-               $aspects = [
-                       wfMessage( 'wikibase-pageinfo-entity-usage-S' 
)->parse(),
+               $aspectsTehran = [
                        wfMessage( 'wikibase-pageinfo-entity-usage-O' 
)->parse(),
                        wfMessage( 'wikibase-pageinfo-entity-usage-L', 'fa' 
)->parse(),
                ];
-               $aspectList = 
RequestContext::getMain()->getLanguage()->commaList( $aspects );
+               $aspectsAthena = [
+                       wfMessage( 'wikibase-pageinfo-entity-usage-S' 
)->parse(),
+               ];
+
+               $lang = RequestContext::getMain()->getLanguage();
+               $aspectListTehran = $lang->commaList( $aspectsTehran );
+               $aspectListAthena = $lang->commaList( $aspectsAthena );
 
                $this->assertContains( 'Tehran', $result );
+               $this->assertContains( 'Athena', $result );
                $this->assertNotContains( '<p class="error"', $result );
                $expected = SpecialPageFactory::getLocalNameFor( 'EntityUsage', 
'Q3' );
                $this->assertContains( $expected, $result );
-               $this->assertContains( $aspectList, $result );
+               $this->assertContains( ': ' . $aspectListTehran . '</li>', 
$result );
+               $this->assertContains( ': ' . $aspectListAthena . '</li>', 
$result );
        }
 
        public function testExecuteWithInvalidParam() {
@@ -77,4 +94,101 @@
                );
        }
 
+       public function testReallyDoQuery() {
+               if ( wfGetDB( DB_REPLICA )->getType() === 'mysql' &&
+                       $this->usesTemporaryTables()
+               ) {
+                       $this->markTestSkipped( 'MySQL does not allow 
self-joins on temporary tables' );
+               }
+               $this->addReallyDoQueryData();
+
+               $special = new SpecialEntityUsage();
+               $special->prepareParams( 'Q3' );
+               $res = $special->reallyDoQuery( 50 );
+               $values = [];
+               $expectedUsages = [
+                       [ 'L.de' ],
+                       [ 'S', 'O' ],
+               ];
+
+               $i = 0;
+               foreach ( $res as $row ) {
+                       $values[] = [
+                               $row->value,
+                               $row->namespace,
+                               $row->title,
+                               $row->eu_page_id
+                       ];
+
+                       $this->assertUsageAspects( $expectedUsages[$i++], 
$row->aspects );
+               }
+
+               $expected = [
+                       [ '22', '0', 'Berlin', '22' ],
+                       [ '11', '0', 'Vienna', '11' ],
+               ];
+
+               $this->assertSame( $expected, $values );
+       }
+
+       private function assertUsageAspects( $expected, $aspectsString ) {
+               // The aspects are not ordered, so don't take this into account 
when asserting
+               $this->assertArrayEquals( $expected, explode( '|', 
$aspectsString ), false );
+       }
+
+       private function addReallyDoQueryData() {
+               $db = wfGetDB( DB_MASTER );
+               $dump = [
+                       'page' => [
+                               [
+                                       'page_title' => 'Vienna',
+                                       'page_namespace' => 0,
+                                       'page_id' => 11,
+                               ],
+                               [
+                                       'page_title' => 'Berlin',
+                                       'page_namespace' => 0,
+                                       'page_id' => 22,
+                               ],
+                       ],
+                       'wbc_entity_usage' => [
+                               [
+                                       'eu_page_id' => 11,
+                                       'eu_entity_id' => 'Q3',
+                                       'eu_aspect' => 'S'
+                               ],
+                               [
+                                       'eu_page_id' => 11,
+                                       'eu_entity_id' => 'Q3',
+                                       'eu_aspect' => 'O'
+                               ],
+                               [
+                                       'eu_page_id' => 11,
+                                       'eu_entity_id' => 'Q4',
+                                       'eu_aspect' => 'L.en'
+                               ],
+                               [
+                                       'eu_page_id' => 22,
+                                       'eu_entity_id' => 'Q3',
+                                       'eu_aspect' => 'L.de'
+                               ],
+                       ],
+               ];
+
+               foreach ( $dump as $table => $rows ) {
+                       // Clean everything
+                       $db->delete( $table, '*' );
+
+                       foreach ( $rows as $row ) {
+                               if ( $table === 'page' ) {
+                                       $title = Title::newFromText( 
$row['page_title'], $row['page_namespace'] );
+                                       $page = WikiPage::factory( $title );
+                                       $page->insertOn( $db, $row['page_id'] );
+                               } else {
+                                       $db->insert( $table, $row );
+                               }
+                       }
+               }
+       }
+
 }
diff --git 
a/extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php 
b/extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
index 0fe4b65..337f5b1 100644
--- a/extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
+++ b/extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
@@ -351,8 +351,8 @@
                        'term_entity_id' => $entityIds,
                );
 
-               if ( $termTypes ) {
-                       $where['term_type'] = $termTypes;
+               if ( $termTypes === null ) {
+                       $termTypes = [ null ];
                }
 
                if ( $languages ) {
@@ -361,14 +361,17 @@
 
                $dbw = $this->getConnection( DB_SLAVE );
 
-               $res = $dbw->select(
-                       $this->termTable,
-                       array( 'term_entity_type', 'term_entity_id', 
'term_type', 'term_language', 'term_text' ),
-                       $where,
-                       __METHOD__
-               );
+               // Do one query per term type here, this is way faster on 
MySQL: T147748
+               foreach ( $termTypes as $termType ) {
+                       $res = $dbw->select(
+                               $this->termTable,
+                               array( 'term_entity_type', 'term_entity_id', 
'term_type', 'term_language', 'term_text' ),
+                               array_merge( $where, $termType !== null ? [ 
'term_type' => $termType ] : [] ),
+                               __METHOD__
+                       );
 
-               $this->injectTerms( $res );
+                       $this->injectTerms( $res );
+               }
 
                $this->releaseConnection( $dbw );
        }
diff --git 
a/extensions/Wikibase/lib/tests/phpunit/Store/EntityInfoBuilderTest.php 
b/extensions/Wikibase/lib/tests/phpunit/Store/EntityInfoBuilderTest.php
index 8b3730a..c3c59da 100644
--- a/extensions/Wikibase/lib/tests/phpunit/Store/EntityInfoBuilderTest.php
+++ b/extensions/Wikibase/lib/tests/phpunit/Store/EntityInfoBuilderTest.php
@@ -189,14 +189,14 @@
 
        public function collectTermsProvider() {
                return array(
-                       array(
+                       'empty set' => array(
                                array(),
                                null,
                                null,
                                array()
                        ),
 
-                       array(
+                       'all term types' => array(
                                array(
                                        new ItemId( 'Q1' ),
                                        new PropertyId( 'P3' ),
@@ -229,7 +229,7 @@
                                )
                        ),
 
-                       array(
+                       'one term type' => array(
                                array(
                                        new ItemId( 'Q1' ),
                                        new PropertyId( 'P3' ),
@@ -247,6 +247,34 @@
                                        'Q7' => array( 'id' => 'Q7', 'type' => 
Item::ENTITY_TYPE, 'labels' => array() ),
                                )
                        ),
+
+                       'two term types' => array(
+                               array(
+                                       new ItemId( 'Q1' ),
+                                       new PropertyId( 'P3' ),
+                                       new ItemId( 'Q7' ),
+                               ),
+                               array( 'label', 'description' ),
+                               null,
+                               array(
+                                       'Q1' => array( 'id' => 'Q1', 'type' => 
Item::ENTITY_TYPE,
+                                               'labels' => 
$this->makeLanguageValueRecords( array(
+                                                       'en' => 'label:Q1/en', 
'de' => 'label:Q1/de' ) ),
+                                               'descriptions' => 
$this->makeLanguageValueRecords( array(
+                                                       'en' => 
'description:Q1/en', 'de' => 'description:Q1/de' ) )
+                                       ),
+                                       'P3' => array( 'id' => 'P3', 'type' => 
Property::ENTITY_TYPE,
+                                               'labels' => 
$this->makeLanguageValueRecords( array(
+                                                       'en' => 'label:P3/en', 
'de' => 'label:P3/de' ) ),
+                                               'descriptions' => 
$this->makeLanguageValueRecords( array(
+                                                       'en' => 
'description:P3/en', 'de' => 'description:P3/de' ) )
+                                       ),
+                                       'Q7' => array( 'id' => 'Q7', 'type' => 
Item::ENTITY_TYPE,
+                                               'labels' => array(),
+                                               'descriptions' => array()
+                                       ),
+                               )
+                       ),
                );
        }
 
diff --git a/extensions/Wikibase/repo/i18n/de.json 
b/extensions/Wikibase/repo/i18n/de.json
index b20d78c..5762a17 100644
--- a/extensions/Wikibase/repo/i18n/de.json
+++ b/extensions/Wikibase/repo/i18n/de.json
@@ -104,7 +104,9 @@
        "wikibase-claimview-snak-tooltip": "Gib einen Wert ein, der der 
Eigenschaft namens „$1“ entspricht. Falls die Eigenschaft keinen bestimmten 
Wert hat oder der derzeitige Wert unbekannt ist, kannst du einen alternativen 
Werttyp wählen, indem du auf das Symbol vor dem Eingabekasten klickst.",
        "wikibase-claimview-snak-new-tooltip": "Nach der Festlegung einer 
Eigenschaft kannst du einen dazugehörigen Wert eingeben. Falls die Eigenschaft 
keinen bestimmten Wert hat oder der derzeitige Wert unbekannt ist, kannst du 
einen alternativen Werttyp wählen, indem du auf das Symbol vor dem 
Eingabekasten klickst.",
        "wikibase-statementview-rank-preferred": "Bevorzugter Rang",
+       "wikibase-statementview-rank-tooltip-preferred": "Gültiger und 
aktueller Wert",
        "wikibase-statementview-rank-normal": "Normaler Rang",
+       "wikibase-statementview-rank-tooltip-normal": "Gültiger Wert, jedoch 
vermutlich historisch",
        "wikibase-statementview-rank-deprecated": "Missbilligter Rang",
        "wikibase-statementview-references-counter": 
"$1{{PLURAL:$2|0=|$3+$2$4}} {{PLURAL:$1|Fundstelle|Fundstellen}}",
        "wikibase-statementview-referencesheading-pendingcountertooltip": 
"{{PLURAL:$1|Ein Beleg wurde|$1 Belege wurden}} noch nicht gespeichert",
diff --git a/extensions/Wikibase/repo/i18n/en.json 
b/extensions/Wikibase/repo/i18n/en.json
index ffc0e8f..177580b 100644
--- a/extensions/Wikibase/repo/i18n/en.json
+++ b/extensions/Wikibase/repo/i18n/en.json
@@ -91,8 +91,11 @@
        "wikibase-claimview-snak-tooltip": "Enter a value corresponding to the 
property named \"$1\". If the property has no designated value or the actual 
value is not known, you can choose an alternative value type by clicking the 
icon before the input box.",
        "wikibase-claimview-snak-new-tooltip": "After specifying a property you 
can enter a corresponding value. If the property has no designated value or the 
actual value is not known, you can choose an alternative value type by clicking 
the icon before the input box.",
        "wikibase-statementview-rank-preferred": "Preferred rank",
+       "wikibase-statementview-rank-tooltip-preferred": "Valid and up-to-date 
value",
        "wikibase-statementview-rank-normal": "Normal rank",
+       "wikibase-statementview-rank-tooltip-normal": "Valid value, though 
possibly historic",
        "wikibase-statementview-rank-deprecated": "Deprecated rank",
+       "wikibase-statementview-rank-tooltip-deprecated": "Value is known to be 
wrong but (used to be) commonly believed",
        "wikibase-statementview-references-counter": 
"$1{{PLURAL:$2|0=|$3+$2$4}} {{PLURAL:$1|reference|references}}",
        "wikibase-statementview-referencesheading-pendingcountertooltip": 
"{{PLURAL:$1|One reference|$1 references}} not saved yet",
        "wikibase-snakview-property-input-placeholder": "property",
diff --git a/extensions/Wikibase/repo/i18n/pt.json 
b/extensions/Wikibase/repo/i18n/pt.json
index 860b1cd..d54046e 100644
--- a/extensions/Wikibase/repo/i18n/pt.json
+++ b/extensions/Wikibase/repo/i18n/pt.json
@@ -207,7 +207,7 @@
        "wikibase-itemmerge-cant-load-entity-content": "Falha ao carregar o 
item.",
        "wikibase-itemmerge-cant-merge-self": "Não é possível fundir um item 
com ele mesmo.",
        "special-dispatchstats": "Estatísticas de envio de alterações",
-       "wikibase-dispatchstats-no-stats": "Não existem estatísticas 
disponíveis actualmente.",
+       "wikibase-dispatchstats-no-stats": "Não existem estatísticas 
disponíveis atualmente.",
        "wikibase-dispatchstats-change-id": "ID",
        "wikibase-dispatchstats-change-timestamp": "Data e hora",
        "wikibase-dispatchstats-oldest-change": "Mais antigo",
@@ -250,7 +250,7 @@
        "wikibase-redirectentity-submit": "Redirecionar",
        "wikibase-api-unresolved-redirect": "O identificador (ID) fornecido 
refere-se a um redirecionamento, o que não é suportado neste contexto.",
        "wikibase-api-no-such-sitelink": "Não foi possível encontrar uma 
ligação de sítio para '$1' ao tentar editar os emblemas.",
-       "wikibase-conflict-patched": "A sua edição foi actualizada para a 
versão mais recente.",
+       "wikibase-conflict-patched": "A sua edição foi adicionada à versão mais 
recente.",
        "wikibase-restoreold": "restaurar",
        "wikibase-entity-summary-restore": "Restaurar revisão $3 por 
[[Special:Contributions/$4|{{GENDER:$4|$4}}]]",
        "wikibase-noentity": "Este conjunto de dados não existe. 
Pode\n[{{fullurl:{{#Special:Log}}|page={{FULLPAGENAMEE}}}} pesquisar os 
registos relacionados]\npara descobrir o que lhe sucedeu.",
diff --git a/extensions/Wikibase/repo/i18n/qqq.json 
b/extensions/Wikibase/repo/i18n/qqq.json
index 1493122..2e4151b 100644
--- a/extensions/Wikibase/repo/i18n/qqq.json
+++ b/extensions/Wikibase/repo/i18n/qqq.json
@@ -122,8 +122,11 @@
        "wikibase-claimview-snak-tooltip": "Tooltip message displayed when 
hovering/clicking the help icon next to the save, cancel and remove links of a 
claim (see [[d:Wikidata:Glossary#Claim]]).\n\nParameters:\n* $1 - the property 
name the user is about to edit a value of or add another value to",
        "wikibase-claimview-snak-new-tooltip": "Tooltip message displayed when 
hovering/clicking the help icon next to the save, cancel and remove links of a 
claim (see [[d:Wikidata:Glossary]]) when about to add a completely new claim 
which includes specifying the property.",
        "wikibase-statementview-rank-preferred": "Label of the 
[[d:Wikidata:Glossary#Rank-preferred|Preferred Rank]] item within the menu that 
allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]] 
[[d:Wikidata:Glossary#Rank|Rank]]. The message is additionally used as tooltip 
on the rank icon when the statement has assigned the Preferred rank.",
+       "wikibase-statementview-rank-tooltip-preferred": "Tooltip of the 
[[d:Wikidata:Glossary#Rank-preferred|Preferred Rank]] item within the menu that 
allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]] 
[[d:Wikidata:Glossary#Rank|Rank]].",
        "wikibase-statementview-rank-normal": "Label of the 
[[d:Wikidata:Glossary#Rank-normal|Normal Rank]] item within the menu that 
allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]] 
[[d:Wikidata:Glossary#Rank|Rank]]. The message is additionally used as tooltip 
on the rank icon when the statement has assigned the Normal Rank.",
+       "wikibase-statementview-rank-tooltip-normal": "Tooltip of the 
[[d:Wikidata:Glossary#Rank-normal|Normal Rank]] item within the menu that 
allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]] 
[[d:Wikidata:Glossary#Rank|Rank]].",
        "wikibase-statementview-rank-deprecated": "Label of the 
[[d:Wikidata:Glossary#Rank-deprecated|Deprecated Rank]] item within the menu 
that allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]] 
[[d:Wikidata:Glossary#Rank|Rank]]. The message is additionally used as tooltip 
on the rank icon when the statement has assigned the Deprecated Rank.",
+       "wikibase-statementview-rank-tooltip-deprecated": "Tooltip of the 
[[d:Wikidata:Glossary#Rank-deprecated|Deprecated Rank]] item within the menu 
that allows adjusting a [[d:Wikidata:Glossary#Statement|Statement's]] 
[[d:Wikidata:Glossary#Rank|Rank]].",
        "wikibase-statementview-references-counter": "Used in the heading for 
the references associated with a statement (see [[d:Wikidata:Glossary]]). The 
heading is giving information about how many references exist for that 
statement. This is the whole heading. The number of unsaved references should 
only be displayed if it's not zero. In that case, it is wrapped by $3 and $4 to 
add an HTML tooltip.\n\nParameters:\n* $1 - the number of saved references\n* 
$2 - the number of unsaved references\n* $3 - placeholder for HTML wrapping the 
number of unsaved references, if displayed (beginning)\n* $4 - placeholder for 
HTML wrapping the number of unsaved references, if displayed 
(end)\n{{Identical|Reference}}",
        "wikibase-statementview-referencesheading-pendingcountertooltip": 
"Tooltip displayed in the references heading when there are references (see 
[[d:Wikidata:Glossary]]) in edit mode which are not saved 
yet.\n\nParameters:\n* $1 - the number of elements not saved yet",
        "wikibase-snakview-property-input-placeholder": "Placeholder message 
that is initially displayed within the property input element when adding a new 
snak. See also [[d:Wikidata:Glossary]].\n{{Identical|Property}}",
diff --git 
a/extensions/Wikibase/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
 
b/extensions/Wikibase/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
index 79cb7a0..29ab036 100644
--- 
a/extensions/Wikibase/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
+++ 
b/extensions/Wikibase/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
@@ -208,6 +208,7 @@
                                        .append(
                                                $( '<a/>' )
                                                .text( mw.msg( 
'wikibase-statementview-rank-' + rankName ) )
+                                               .attr( 'title', mw.msg( 
'wikibase-statementview-rank-tooltip-' + rankName ) )
                                                .on( 'click.' + 
self.widgetName, function( event ) {
                                                        event.preventDefault();
                                                } )
diff --git a/extensions/Wikibase/view/resources/jquery/wikibase/resources.php 
b/extensions/Wikibase/view/resources/jquery/wikibase/resources.php
index d3c1a46..2c70db8 100644
--- a/extensions/Wikibase/view/resources/jquery/wikibase/resources.php
+++ b/extensions/Wikibase/view/resources/jquery/wikibase/resources.php
@@ -418,8 +418,11 @@
                                'wikibase-claimview-snak-tooltip',
                                'wikibase-claimview-snak-new-tooltip',
                                'wikibase-statementview-rank-preferred',
+                               'wikibase-statementview-rank-tooltip-preferred',
                                'wikibase-statementview-rank-normal',
+                               'wikibase-statementview-rank-tooltip-normal',
                                'wikibase-statementview-rank-deprecated',
+                               
'wikibase-statementview-rank-tooltip-deprecated',
                                'wikibase-statementview-references-counter',
                                
'wikibase-statementview-referencesheading-pendingcountertooltip',
                        ),
diff --git a/vendor/composer/installed.json b/vendor/composer/installed.json
index 82ca641..e053995 100644
--- a/vendor/composer/installed.json
+++ b/vendor/composer/installed.json
@@ -1348,12 +1348,12 @@
         "source": {
             "type": "git",
             "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
-            "reference": "7f7a926567984089c1c157da35f19260d18bd7c9"
+            "reference": "f565a7192b96d565677eb6f8661417b574d2eb80"
         },
         "dist": {
             "type": "zip",
-            "url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/7f7a926567984089c1c157da35f19260d18bd7c9";,
-            "reference": "7f7a926567984089c1c157da35f19260d18bd7c9",
+            "url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/f565a7192b96d565677eb6f8661417b574d2eb80";,
+            "reference": "f565a7192b96d565677eb6f8661417b574d2eb80",
             "shasum": ""
         },
         "require": {
@@ -1386,7 +1386,7 @@
             "jakub-onderka/php-parallel-lint": "0.9.2",
             "mediawiki/mediawiki-codesniffer": "0.4.0|0.5.0"
         },
-        "time": "2016-10-13 08:27:02",
+        "time": "2016-10-13 20:55:34",
         "type": "mediawiki-extension",
         "installation-source": "dist",
         "autoload": {

-- 
To view, visit https://gerrit.wikimedia.org/r/315922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idaa3ee8dcc70669b56e04b038ac69c80c41ec5b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: WikidataBuilder <wikidata-servi...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to