jenkins-bot has submitted this change and it was merged.

Change subject: Remove misplaced return from cancelEditing
......................................................................


Remove misplaced return from cancelEditing

Change-Id: I13ede83c157996f88b344239d5f2f4a2874e415f
---
M src/jquery.valueview.valueview.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/jquery.valueview.valueview.js 
b/src/jquery.valueview.valueview.js
index dd4c66b..2c76592 100644
--- a/src/jquery.valueview.valueview.js
+++ b/src/jquery.valueview.valueview.js
@@ -336,7 +336,7 @@
         * before the edit mode has been started.
         */
        cancelEditing: function() {
-               return this.stopEditing( true );
+               this.stopEditing( true );
        },
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/315906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13ede83c157996f88b344239d5f2f4a2874e415f
Gerrit-PatchSet: 1
Gerrit-Project: data-values/value-view
Gerrit-Branch: master
Gerrit-Owner: Thiemo M├Ąttig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to