Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315981
Change subject: Don't fatal on newer Echo versions
......................................................................
Don't fatal on newer Echo versions
Use an is_callable check to make sure what we're calling still exists.
But really we should update this to use the newer Echo API.
Change-Id: I311dd90e238e840210d77b719bba2a54dcab8fde
---
M BlueSkyTemplate.php
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/BlueSky
refs/changes/81/315981/1
diff --git a/BlueSkyTemplate.php b/BlueSkyTemplate.php
index db1f446..4bdd4bd 100644
--- a/BlueSkyTemplate.php
+++ b/BlueSkyTemplate.php
@@ -888,8 +888,11 @@
$html = '';
$user = $this->getSkin()->getUser();
- if ( class_exists( 'EchoEvent' ) && $this->userHasCookies() ) {
+ if ( is_callable( [ ApiEchoNotifications::class,
'getNotifications' ] )
+ && $user->isLoggedIn()
+ ) {
$maxNotesShown = 5;
+ // FIXME update this to the newer Echo API
$notif = ApiEchoNotifications::getNotifications( $user,
'html', $maxNotesShown );
if ( $notif ) {
--
To view, visit https://gerrit.wikimedia.org/r/315981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I311dd90e238e840210d77b719bba2a54dcab8fde
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/BlueSky
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
