jenkins-bot has submitted this change and it was merged.

Change subject: commonPrint: Remove overqualified selectors & `!important` 
where applicable
......................................................................


commonPrint: Remove overqualified selectors & `!important` where applicable

Removing overqualified CSS selectors and use of `important` where
applicable (CSSLint). Also deleting obsolete `a.sortheader` rule.

Bug: T136459
Change-Id: I2ed1c7188c96d6205ee03dc46a2a90130c8d120a
---
M resources/src/mediawiki.legacy/commonPrint.css
1 file changed, 8 insertions(+), 13 deletions(-)

Approvals:
  TheDJ: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/src/mediawiki.legacy/commonPrint.css 
b/resources/src/mediawiki.legacy/commonPrint.css
index d387a2d..ec94df3 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -10,10 +10,9 @@
  * Hide all the elements irrelevant for printing
  */
 .noprint,
-div#jump-to-nav,
+#jump-to-nav,
 .mw-jump,
-div.top,
-div#column-one,
+#column-one,
 .mw-editsection,
 .mw-editsection-like,
 #footer-places,
@@ -21,12 +20,12 @@
 .usermessage,
 .patrollink,
 .ns-0 .mw-redirectedfrom,
-div.magnify,
+.magnify,
 #mw-navigation,
 #siteNotice,
 /* Deprecated, changed in core */
-div#f-poweredbyico,
-div#f-copyrightico,
+#f-poweredbyico,
+#f-copyrightico,
 li#about,
 li#disclaimer,
 li#mobileview,
@@ -228,7 +227,7 @@
        font-style: italic;
 }
 
-div.center {
+.center {
        text-align: center;
 }
 
@@ -246,7 +245,7 @@
 div.thumbinner {
        background-color: #fff;
        border: 1pt solid #ccc;
-       padding: 3px !important;
+       padding: 3px;
        font-size: 94%;
        text-align: center;
        /* new block formatting context,
@@ -262,7 +261,7 @@
        border: none;
        text-align: left;
        line-height: 1.4em;
-       padding: 3px !important;
+       padding: 3px;
        font-size: 94%;
 }
 
@@ -323,10 +322,6 @@
 table.listing td {
        border: 1pt solid #000;
        border-collapse: collapse;
-}
-
-a.sortheader {
-       margin: 0 0.3em;
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/313363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ed1c7188c96d6205ee03dc46a2a90130c8d120a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Fomafix <foma...@googlemail.com>
Gerrit-Reviewer: GWicke <gwi...@wikimedia.org>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to