Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315992

Change subject: linter: Only send 1 log entry per image for bogus image options
......................................................................

linter: Only send 1 log entry per image for bogus image options

Change-Id: Ic4aecc03b337852804dc5cb10b82a0f7b423caf7
---
M lib/wt2html/pp/handlers/linter.js
1 file changed, 17 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/92/315992/1

diff --git a/lib/wt2html/pp/handlers/linter.js 
b/lib/wt2html/pp/handlers/linter.js
index abcd25a..a2fe6ec 100644
--- a/lib/wt2html/pp/handlers/linter.js
+++ b/lib/wt2html/pp/handlers/linter.js
@@ -237,25 +237,27 @@
 function logBogusImageOptions(env, c, dp, tplInfo) {
        if (DU.isGeneratedFigure(c)) {
                var optlist = dp.optList;
+               var dsr;
+               var inTransclusion = false;
+               if (tplInfo) {
+                       dsr = tplInfo.dsr;
+                       inTransclusion = true;
+               } else {
+                       dsr = dp.dsr;
+               }
+               var lintObj = {
+                       src: env.page.src,
+                       dsr: dsr,
+                       inTransclusion: inTransclusion,
+                       params: { items: [] },
+               };
+               var keys = [];
                optlist.forEach(function(item) {
                        if (item.ck === "bogus") {
-                               var dsr;
-                               var inTransclusion = false;
-                               if (tplInfo) {
-                                       dsr = tplInfo.dsr;
-                                       inTransclusion = true;
-                               } else {
-                                       dsr = dp.dsr;
-                               }
-                               var lintObj = {
-                                       src: env.page.src,
-                                       dsr: dsr,
-                                       inTransclusion: inTransclusion,
-                                       params: { name: item.ak },
-                               };
-                               env.log('lint/bogus-image-options', lintObj);
+                               lintObj.params.items.push( item.ak );
                        }
                });
+               env.log('lint/bogus-image-options', lintObj);
        }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/315992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4aecc03b337852804dc5cb10b82a0f7b423caf7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to