Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/316002
Change subject: MediaWiki.php: MAke getUrlDomainDistance() actually static ...................................................................... MediaWiki.php: MAke getUrlDomainDistance() actually static It's only called once, and that call is static. It also doesn't use $this. [error] [0f03a710dee98e2106863be9] /w/index.php?title=New_new_page&action=purge ErrorException from line 610 of /vagrant/mediawiki/includes/MediaWiki.php: PHP Strict Standards: Non-static method MediaWiki::getUrlDomainDistance() should not be called statically Change-Id: Ice66937a32193720c52df39bcea90659a8d9f653 --- M includes/MediaWiki.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/02/316002/1 diff --git a/includes/MediaWiki.php b/includes/MediaWiki.php index 218337a..f21128e 100644 --- a/includes/MediaWiki.php +++ b/includes/MediaWiki.php @@ -678,7 +678,7 @@ * @param IContextSource $context * @return string|bool Either "local" or "remote" if in the farm, false otherwise */ - private function getUrlDomainDistance( $url, IContextSource $context ) { + private static function getUrlDomainDistance( $url, IContextSource $context ) { static $relevantKeys = [ 'host' => true, 'port' => true ]; $infoCandidate = wfParseUrl( $url ); -- To view, visit https://gerrit.wikimedia.org/r/316002 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ice66937a32193720c52df39bcea90659a8d9f653 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Catrope <r...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits