jenkins-bot has submitted this change and it was merged.

Change subject: Fix undefined $htmlDiff
......................................................................


Fix undefined $htmlDiff

Bug: T138813
Change-Id: Id775345955c480f0cb2e4d0eb695c303372e0ccb
---
M MassEditRegex.special.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Reedy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MassEditRegex.special.php b/MassEditRegex.special.php
index 157b403..d8b9a6b 100644
--- a/MassEditRegex.special.php
+++ b/MassEditRegex.special.php
@@ -54,9 +54,10 @@
                $pageCountLimit = $isPreview ? MER_MAX_PREVIEW_DIFFS : 
MER_MAX_EXECUTE_PAGES;
                $errors = array();
 
+               $htmlDiff = '';
+
                if ( $isPreview ) {
                        $this->massEditRegex->getDiffEngine()->showDiffStyle();
-                       $htmlDiff = '';
                } else {
                        $wgOut->addHTML( '<ul>' );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/309843
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id775345955c480f0cb2e4d0eb695c303372e0ccb
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MassEditRegex
Gerrit-Branch: master
Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to