Jcrespo has submitted this change and it was merged.

Change subject: Overwrite (or create) init.d with custom one
......................................................................


Overwrite (or create) init.d with custom one

Old package require manual installation. Now it is done
automatically.
New packages do not include it by default (or they are wrong).
This class overwrites the init.d script with the one that is
current installed from the old packages, to maintain 100%
compatibility.

In the future, mariadb::service will include a custom systemd
unit, but that is not yet possible with mariadb10.

This has to be parametrized to allow different packages other
than 10.0.

Change-Id: I3543a095bd240c190155aeb2753ba9605edc1b1f
---
M manifests/packages_wmf.pp
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Jcrespo: Looks good to me, approved
  Marostegui: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/manifests/packages_wmf.pp b/manifests/packages_wmf.pp
index 668dd5e..eb0a010 100644
--- a/manifests/packages_wmf.pp
+++ b/manifests/packages_wmf.pp
@@ -34,6 +34,14 @@
 
     # if you have installed the wmf mariadb package,
     # create a custom, safer mysqld_safe
-    # Required until a new package is created
+    # New packages include it, but old packages have
+    # to be overwritten still
     include mariadb::mysqld_safe
+    # Also create a custom, safer mysql start/stop
+    # script
+    # Required until all packages are updated to
+    # a systemd-compatible binary
+    if ($mariadb10 == true) {
+        include mariadb::service
+    }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/316334
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3543a095bd240c190155aeb2753ba9605edc1b1f
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet/mariadb
Gerrit-Branch: master
Gerrit-Owner: Jcrespo <jcre...@wikimedia.org>
Gerrit-Reviewer: Jcrespo <jcre...@wikimedia.org>
Gerrit-Reviewer: Marostegui <maroste...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to