jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: update WikiSite comments
......................................................................
Hygiene: update WikiSite comments
Change-Id: Ib15b80ea0257ff854fc7346862e91f3b23d3bc7c
---
M app/src/main/java/org/wikipedia/dataclient/WikiSite.java
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
BearND: Looks good to me, but someone else must approve
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/dataclient/WikiSite.java
b/app/src/main/java/org/wikipedia/dataclient/WikiSite.java
index e31e6ed..867d1ad 100644
--- a/app/src/main/java/org/wikipedia/dataclient/WikiSite.java
+++ b/app/src/main/java/org/wikipedia/dataclient/WikiSite.java
@@ -62,7 +62,8 @@
languageCode);
}
- /** This method cannot resolve multi-dialect wikis like Simplified and
Traditional Chinese. */
+ /** This method cannot resolve multi-dialect wikis like Simplified and
Traditional Chinese as
+ the variant is unavailable. */
public WikiSite(@NonNull String authority) {
this(authority, authorityToLanguageCode(authority));
}
@@ -84,6 +85,10 @@
}
public WikiSite(@NonNull Uri uri, @NonNull String languageCode) {
+ // todo: uncomment
+ // if (!supportedAuthority(uri.getAuthority())) {
+ // throw new IllegalArgumentException("Unsupported authority=" +
uri.getAuthority());
+ // }
this.uri = uri;
this.languageCode = languageCode;
}
@@ -174,7 +179,8 @@
}
/**
- * @return The wiki language code which may differ from the language
subdomain.
+ * @return The wiki language code which may differ from the language
subdomain. Empty if
+ * language code is unknown. Ex: "en", "zh-hans", ""
*
* @see AppLanguageLookUpTable
*/
--
To view, visit https://gerrit.wikimedia.org/r/315459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib15b80ea0257ff854fc7346862e91f3b23d3bc7c
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
