Jkmartindale has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316476

Change subject: Patched to work with MediaWiki 1.27.1
......................................................................

Patched to work with MediaWiki 1.27.1

- Changed $this->user-getSkin() to $this->user in SpecialFavoriteList.php as
suggested by Subfader
- onTitleMoveComplete in FavoritesHooks.php no longer takes $user by
  reference, as suggested by Subfader
- Fixed undefined FavParser::msg() call in FavParser.php by replacing it
  with wfMessage()

Change-Id: I0dedd125345d1ca19254004d4413b87c437870b6
---
M FavParser.php
M FavoritesHooks.php
M SpecialFavoritelist.php
3 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Favorites 
refs/changes/76/316476/2

diff --git a/FavParser.php b/FavParser.php
index 1426344..812d6e0 100644
--- a/FavParser.php
+++ b/FavParser.php
@@ -142,7 +142,7 @@
                        $output .=  $form ;
                        return $output;
                } else {
-                       $output = $this->msg('nofavoritelist')->text();
+                       $output = wfMessage('nofavoritelist')->text();
                        return $output;
                }
        }
diff --git a/FavoritesHooks.php b/FavoritesHooks.php
index d03f9db..d334ef4 100644
--- a/FavoritesHooks.php
+++ b/FavoritesHooks.php
@@ -66,7 +66,7 @@
                return true;
        }
        
-       public static function onTitleMoveComplete( &$title, &$nt, &$user, 
$pageid, $redirid ) {
+       public static function onTitleMoveComplete( &$title, &$nt, $user, 
$pageid, $redirid ) {
                # Update watchlists
                $oldnamespace = $title->getNamespace() & ~1;
                $newnamespace = $nt->getNamespace() & ~1;
diff --git a/SpecialFavoritelist.php b/SpecialFavoritelist.php
index a55e43d..4c60b47 100644
--- a/SpecialFavoritelist.php
+++ b/SpecialFavoritelist.php
@@ -91,7 +91,7 @@
                $this->out->setPageTitle ( wfMessage ( 'favoritelist' ) );
                
                $sub = wfMessage ( 'favoritelistfor', $this->user->getName () 
)->parse ();
-               $sub .= '<br />' . FavoritelistEditor::buildTools ( 
$this->user->getSkin () );
+               $sub .= '<br />' . FavoritelistEditor::buildTools ( $this->user 
);
                $this->out->setSubtitle ( $sub );
                
                if (($mode = FavoritelistEditor::getMode ( $this->request, $par 
)) !== false) {
@@ -112,7 +112,7 @@
                        $this->unfavoriteTitles ( $titles, $user );
                        $user->invalidateCache ();
                        $output->addHTML ( wfMessage ( 
'favoritelistedit-normal-done', $GLOBALS ['wgLang']->formatNum ( count ( 
$titles ) ) )->parse () );
-                       $this->showTitles ( $titles, $output, 
$this->user->getSkin () );
+                       $this->showTitles ( $titles, $output, $this->user );
                }
                $this->showNormalForm ( $output, $user );
                
@@ -307,7 +307,7 @@
                                        ) ) 
                        ) );
                        $form .= Html::hidden ( 'token', 
$this->user->getEditToken ( 'favorite' ) );
-                       $form .= $this->buildRemoveList ( $user, 
$this->user->getSkin () );
+                       $form .= $this->buildRemoveList ( $user, $this->user );
                        $form .= '</fieldset></form>';
                        $output->addHTML ( $form );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/316476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dedd125345d1ca19254004d4413b87c437870b6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Favorites
Gerrit-Branch: master
Gerrit-Owner: Jkmartindale <jkmartind...@live.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to