Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316479

Change subject: Event and hover events are logged but not recorded
......................................................................

Event and hover events are logged but not recorded

This adds two new events "display" and "hover" which are not
recorded back to the server. The benefits of having these events
is that they are important events in the lifecycle of a hovercard.

This allows us to debut trackSubscribe and ensure we see the behaviour
we expect to see.

Change-Id: I1a025d0ba56ed2b017e25a29b232810fd884d927
---
M resources/ext.popups.renderer.desktopRenderer/desktopRenderer.js
M resources/ext.popups.schemaPopups/ext.popups.schemaPopups.js
M resources/ext.popups.targets.desktopTarget/desktopTarget.js
3 files changed, 17 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/79/316479/1

diff --git a/resources/ext.popups.renderer.desktopRenderer/desktopRenderer.js 
b/resources/ext.popups.renderer.desktopRenderer/desktopRenderer.js
index 54aa0d2..e6bf16e 100644
--- a/resources/ext.popups.renderer.desktopRenderer/desktopRenderer.js
+++ b/resources/ext.popups.renderer.desktopRenderer/desktopRenderer.js
@@ -230,6 +230,10 @@
                        namespaceIdHover: cache.settings.namespace,
                        perceivedWait: Math.round( mw.now() - 
logData.dwellStartTime )
                } );
+               mw.track( 'ext.popups.schemaPopups', $.extend( {}, logData, {
+                               action: 'displayed'
+                       } )
+               );
 
                cache.process( link, $.extend( {}, logData ) );
 
diff --git a/resources/ext.popups.schemaPopups/ext.popups.schemaPopups.js 
b/resources/ext.popups.schemaPopups/ext.popups.schemaPopups.js
index afe31b3..4e2215b 100644
--- a/resources/ext.popups.schemaPopups/ext.popups.schemaPopups.js
+++ b/resources/ext.popups.schemaPopups/ext.popups.schemaPopups.js
@@ -9,15 +9,21 @@
                );
 
        mw.trackSubscribe( 'ext.popups.schemaPopups', function ( topic, data ) {
-               var shouldLog = true;
+               // We don't log hover and display events as they are not 
compatible with the schema
+               // but they are useful for debugging
+               var action = data.action,
+                       shouldLog = action && [ 'hover', 'display' ].indexOf( 
action ) === -1;
 
-               data = mw.popups.schemaPopups.getMassagedData( data );
+               // since this method has side effects only restrict to it to 
the things we actually want
+               if ( shouldLog ) {
+                       data = mw.popups.schemaPopups.getMassagedData( data );
+               }
 
                // Only one action is recorded per link interaction token...
                if ( data.linkInteractionToken &&
                        data.linkInteractionToken === 
previousLogData.linkInteractionToken ) {
                        // however, the 'disabled' action takes two clicks by 
nature, so allow it
-                       if ( data.action !== 'disabled' ) {
+                       if ( action !== 'disabled' ) {
                                shouldLog = false;
                        }
                }
diff --git a/resources/ext.popups.targets.desktopTarget/desktopTarget.js 
b/resources/ext.popups.targets.desktopTarget/desktopTarget.js
index f8cb7cd..6ab7258 100644
--- a/resources/ext.popups.targets.desktopTarget/desktopTarget.js
+++ b/resources/ext.popups.targets.desktopTarget/desktopTarget.js
@@ -48,6 +48,10 @@
                                hovercardsSuppressedByGadget: 
isNavigationPopupsGadgetEnabled()
                        };
 
+               mw.track( 'ext.popups.schemaPopups', $.extend( {}, eventData, {
+                       action: 'hover'
+                       } )
+               );
                // Only enable Popups when the Navigation popups gadget is not 
enabled
                if ( !eventData.hovercardsSuppressedByGadget && 
mw.popups.enabled ) {
                        if ( mw.popups.scrolled ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/316479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a025d0ba56ed2b017e25a29b232810fd884d927
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to