John Erling Blad has submitted this change and it was merged. Change subject: Use plural for 'wikibase-comment-multi' and numParams() ......................................................................
Use plural for 'wikibase-comment-multi' and numParams() Even though English only has a single plural form, that's not true for many other languages. Plurals should be declared explicitely where possible. Use wfMessage()->numParams() for parameters that are numbers, so number conversion is used where applicable. Change-Id: I4070ddd85262b8a3f6de10719f250ad2cb8ad329 --- M client/WikibaseClient.i18n.php M client/includes/recentchanges/ExternalChangesLine.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/48091 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4070ddd85262b8a3f6de10719f250ad2cb8ad329 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Siebrand <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
