Gehel has uploaded a new change for review. https://gerrit.wikimedia.org/r/316560
Change subject: service::node: Adding minimal test ...................................................................... service::node: Adding minimal test This does not add much value yet, but opens the way to writing more tests for the service module. Change-Id: I5e58d2d9efe9194ba6e4061a49a974384dfeb084 --- A modules/service/.fixtures.yml A modules/service/.rspec A modules/service/Rakefile A modules/service/spec/defines/service_node_spec.rb A modules/service/spec/spec_helper.rb 5 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/60/316560/1 diff --git a/modules/service/.fixtures.yml b/modules/service/.fixtures.yml new file mode 100644 index 0000000..7c546bd --- /dev/null +++ b/modules/service/.fixtures.yml @@ -0,0 +1,12 @@ +fixtures: + symlinks: + service: "#{source_dir}" + base: "../../../../base" + ferm: "../../../../ferm" + monitoring: "../../../../monitoring" + rsyslog: "../../../../rsyslog" + scap: "../../../../scap" + stdlib: "../../../../stdlib" + systemd: "../../../../systemd" + trebuchet: "../../../../trebuchet" + wmflib: "../../../../wmflib" diff --git a/modules/service/.rspec b/modules/service/.rspec new file mode 100644 index 0000000..f449dae --- /dev/null +++ b/modules/service/.rspec @@ -0,0 +1,2 @@ +--format doc +--color diff --git a/modules/service/Rakefile b/modules/service/Rakefile new file mode 100644 index 0000000..cd3d379 --- /dev/null +++ b/modules/service/Rakefile @@ -0,0 +1 @@ +require 'puppetlabs_spec_helper/rake_tasks' diff --git a/modules/service/spec/defines/service_node_spec.rb b/modules/service/spec/defines/service_node_spec.rb new file mode 100644 index 0000000..983c79c --- /dev/null +++ b/modules/service/spec/defines/service_node_spec.rb @@ -0,0 +1,20 @@ +require 'spec_helper' + +describe 'service::node', :type => :define do + + let(:title) { 'my_service_name' } + let(:facts) { { :initsystem => 'systemd' } } + + context 'when only port is given' do + let(:params) { { :port => 1234 } } + + it 'create application config file' do + is_expected.to contain_file('/etc/my_service_name/config.yaml') + end + it 'logs locally with info level' do + is_expected.to contain_file('/etc/my_service_name/config.yaml') + .with_content(%r{level: info\n\s*path: /srv/log/my_service_name/main\.log}m) + end + end + +end diff --git a/modules/service/spec/spec_helper.rb b/modules/service/spec/spec_helper.rb new file mode 100644 index 0000000..26af1be --- /dev/null +++ b/modules/service/spec/spec_helper.rb @@ -0,0 +1,8 @@ +require 'puppetlabs_spec_helper/module_spec_helper' + +fixture_path = File.expand_path(File.join(__FILE__, '..', 'fixtures')) + +RSpec.configure do |c| + c.module_path = File.join(fixture_path, 'modules') + c.manifest_dir = File.join(fixture_path, 'manifests') +end -- To view, visit https://gerrit.wikimedia.org/r/316560 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e58d2d9efe9194ba6e4061a49a974384dfeb084 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Gehel <gleder...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits