jenkins-bot has submitted this change and it was merged.

Change subject: Always load CSS, not only when the create button is there
......................................................................


Always load CSS, not only when the create button is there

Change-Id: I438dafde39a91b9a0fba9546fc1507394eebf370
---
M includes/AboutTopicRenderer.php
1 file changed, 8 insertions(+), 6 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/AboutTopicRenderer.php b/includes/AboutTopicRenderer.php
index b3dd674..b787c24 100644
--- a/includes/AboutTopicRenderer.php
+++ b/includes/AboutTopicRenderer.php
@@ -77,12 +77,14 @@
         * @param OutputPage $output
         */
        public function showPlaceholder(
-                       ItemId $entityId,
-                       Language $language,
-                       User $user,
-                       OutputPage $output
-               ) {
+               ItemId $entityId,
+               Language $language,
+               User $user,
+               OutputPage $output
+       ) {
+               $output->addModuleStyles( 
'ext.articleplaceholder.defaultDisplay' );
                $output->addWikiText( '{{aboutTopic|' . 
$entityId->getSerialization() . '}}' );
+
                $label = $this->getLabel( $entityId, $language );
                $labelTitle = null;
                if ( $label ) {
@@ -92,6 +94,7 @@
                if ( $labelTitle && $labelTitle->quickUserCan( 'createpage', 
$user ) ) {
                        $this->showCreateArticle( $labelTitle, $output );
                }
+
                $this->showLanguageLinks( $entityId, $output );
        }
 
@@ -102,7 +105,6 @@
         */
        private function showCreateArticle( Title $labelTitle, OutputPage 
$output ) {
                $output->enableOOUI();
-               $output->addModuleStyles( 
'ext.articleplaceholder.defaultDisplay' );
                $output->addModules( 'ext.articleplaceholder.createArticle' );
                $output->addJsConfigVars( 'apLabel', 
$labelTitle->getPrefixedText() );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/316570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I438dafde39a91b9a0fba9546fc1507394eebf370
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Lucie Kaffee <lucie.kaf...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to