Yaron Koren has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316805

Change subject: Add file data to "page values" display
......................................................................

Add file data to "page values" display

Change-Id: I70bac9356e147062af55682479869c70fae40b42
---
M specials/CargoPageValues.php
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/05/316805/2

diff --git a/specials/CargoPageValues.php b/specials/CargoPageValues.php
index 1211295..2561214 100644
--- a/specials/CargoPageValues.php
+++ b/specials/CargoPageValues.php
@@ -17,7 +17,7 @@
        }
 
        function execute( $subpage = null ) {
-               global $wgCargoPageDataColumns;
+               global $wgCargoPageDataColumns, $wgCargoFileDataColumns;
 
                if ( $subpage ) {
                        // Allow inclusion with e.g. {{Special:PageValues/Book}}
@@ -42,10 +42,14 @@
 
                $tableNames = array();
 
-               // Make _pageData the first table, if it holds any real data.
+               // Make _pageData and _fileData the first two tables, if
+               // either of them hold any real data.
                if ( count( $wgCargoPageDataColumns ) > 0 ) {
                        $tableNames[] = '_pageData';
                }
+               if ( count( $wgCargoFileDataColumns ) > 0 ) {
+                       $tableNames[] = '_fileData';
+               }
 
                $res = $dbw->select(
                        'cargo_pages', 'table_name', array( 'page_id' => 
$this->mTitle->getArticleID() ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/316805
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I70bac9356e147062af55682479869c70fae40b42
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to