Yaron Koren has submitted this change and it was merged.
Change subject: Small fix for Special:Drilldown
......................................................................
Small fix for Special:Drilldown
Change-Id: I9a1693c854db510067cb62d41bf92294422a0965
---
M drilldown/CargoSpecialDrilldown.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Yaron Koren: Looks good to me, approved
jenkins-bot: Verified
diff --git a/drilldown/CargoSpecialDrilldown.php
b/drilldown/CargoSpecialDrilldown.php
index 673798f..feb92ef 100644
--- a/drilldown/CargoSpecialDrilldown.php
+++ b/drilldown/CargoSpecialDrilldown.php
@@ -1025,6 +1025,7 @@
foreach ( $this->all_filters as $f ) {
foreach ( $this->applied_filters as $af ) {
if ( $af->filter->name == $f->name ) {
+ $fieldType =
$f->fieldDescription->mType;
if ( $fieldType == 'Date' || $fieldType
== 'Integer' || $fieldType == 'Float' ) {
$filtersHTML .=
$this->printUnappliedFilterLine( $f );
} else {
@@ -1037,11 +1038,10 @@
$filtersHTML .=
$this->printUnappliedFilterLine( $rf, $cur_url );
}
}
- $numFilters++;
}
$filtersHTML .= " </div> <!--
drilldown-filters -->\n";
- if ( $numFilters == 0 ) {
+ if ( count( $this->all_filters ) == 0 ) {
return '';
}
--
To view, visit https://gerrit.wikimedia.org/r/316808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a1693c854db510067cb62d41bf92294422a0965
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
