Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316810
Change subject: graphite: change Cassandra '.count' metrics aggregation
......................................................................
graphite: change Cassandra '.count' metrics aggregation
Also clarify in comments why the default aggregation schema comes last with
'zzddefault'.
Bug: T121789
Change-Id: I43fbb699a6643ebb74fee63d40bc9ca2d211170b
---
M modules/role/manifests/graphite/base.pp
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/10/316810/1
diff --git a/modules/role/manifests/graphite/base.pp
b/modules/role/manifests/graphite/base.pp
index 0b36189..40f42dd 100644
--- a/modules/role/manifests/graphite/base.pp
+++ b/modules/role/manifests/graphite/base.pp
@@ -66,6 +66,13 @@
# Aggregation methods for whisper files.
storage_aggregation => {
+ # Cassandra "count" metrics are treated like gauges, not like
+ # statsd "counters". See also T121789 for rationale.
+ '10_cassandra_count' => {
+ pattern => '^cassandra\..*\.count$',
+ xFilesFactor => 0.01,
+ aggregationMethod => 'avg',
+ },
'min' => {
pattern => '\.min$',
xFilesFactor => 0.01,
@@ -97,7 +104,11 @@
xFilesFactor => 0.01,
aggregationMethod => 'max',
},
- 'default' => {
+ # Like storage_schemas, this hash is written in order in the
+ # configuration file and read in order by graphite
+ # (lib/carbon/storage.py). Therefore put default as last item for
+ # matching to work correctly.
+ 'zzdefault' => {
pattern => '.*',
xFilesFactor => 0.01,
},
--
To view, visit https://gerrit.wikimedia.org/r/316810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43fbb699a6643ebb74fee63d40bc9ca2d211170b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
