jenkins-bot has submitted this change and it was merged.
Change subject: fix logic introduced in addNewAccountInternal
......................................................................
fix logic introduced in addNewAccountInternal
Jenkins' PHP codesniffer complains about the whitespace at line 318.
I'm pretty sure gerrit 17952 (commit 69ea4400) introduced bad logic.
Part of the if statement boils down to
userExists( userName || authenticate( userName, password) )
if userName is falsy then it calls userExists on the boolean return
value of authenticate(). I think this change puts it back to the way it
was.
Change-Id: If334464ffa993490abe8919591a18a4c3935bcfb
---
M includes/specials/SpecialUserlogin.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
CSteipp: Looks good to me, approved
jenkins-bot: Verified
--
To view, visit https://gerrit.wikimedia.org/r/48095
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If334464ffa993490abe8919591a18a4c3935bcfb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
