jenkins-bot has submitted this change and it was merged.
Change subject: Link external ids when used in Wikitext
......................................................................
Link external ids when used in Wikitext
Bug: T148025
Change-Id: I1adeb089aaf6ac44a441344cc8348f49b512a147
---
M client/WikibaseClient.datatypes.php
1 file changed, 26 insertions(+), 20 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/WikibaseClient.datatypes.php
b/client/WikibaseClient.datatypes.php
index ed1a7a5..2919d67 100644
--- a/client/WikibaseClient.datatypes.php
+++ b/client/WikibaseClient.datatypes.php
@@ -35,61 +35,67 @@
// NOTE: Factory callbacks are registered below by value type (using
the prefix "VT:") or by
// property data type (prefix "PT:").
- return array(
- 'VT:bad' => array(
+ return [
+ 'VT:bad' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return
$factory->newUnDeserializableValueFormatter( $format, $options );
}
- ),
- 'VT:globecoordinate' => array(
+ ],
+ 'VT:globecoordinate' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return $factory->newGlobeCoordinateFormatter(
$format, $options );
},
- ),
- 'VT:monolingualtext' => array(
+ ],
+ 'VT:monolingualtext' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return $factory->newMonolingualFormatter(
$format, $options );
},
- ),
- 'VT:quantity' => array(
+ ],
+ 'VT:quantity' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return $factory->newQuantityFormatter( $format,
$options );
},
- ),
- 'VT:string' => array(
+ ],
+ 'VT:string' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return $factory->newStringFormatter( $format,
$options );
},
- ),
- 'PT:url' => array(
+ ],
+ 'PT:url' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return $factory->newUrlFormatter( $format,
$options );
},
- ),
- 'PT:commonsMedia' => array(
+ ],
+ 'PT:commonsMedia' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return $factory->newCommonsMediaFormatter(
$format, $options );
},
- ),
- 'VT:time' => array(
+ ],
+ 'VT:time' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return $factory->newTimeFormatter( $format,
$options );
},
- ),
- 'VT:wikibase-entityid' => array(
+ ],
+ 'VT:wikibase-entityid' => [
'formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
$factory =
WikibaseClient::getDefaultValueFormatterBuilders();
return $factory->newEntityIdFormatter( $format,
$options );
},
- ),
- );
+ ],
+ 'PT:external-id' => [
+ 'snak-formatter-factory-callback' => function( $format,
FormatterOptions $options ) {
+ $factory =
WikibaseClient::getDefaultSnakFormatterBuilders();
+ return
$factory->newExternalIdentifierFormatter( $format, $options );
+ },
+ ],
+ ];
} );
--
To view, visit https://gerrit.wikimedia.org/r/288524
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1adeb089aaf6ac44a441344cc8348f49b512a147
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Lucie Kaffee <lucie.kaf...@wikimedia.de>
Gerrit-Reviewer: Lydia Pintscher <lydia.pintsc...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
