Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317010
Change subject: Add content descriptions to article toolbar
......................................................................
Add content descriptions to article toolbar
Make the page toolbar more accessible by adding
android:contentDescriptions to each iconic button. These tips are also
available on long press.
Change-Id: Ib7134bca2899db517765b533ea6deb4e185166ad
---
M app/src/main/res/layout/view_article_tab_layout.xml
1 file changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/10/317010/1
diff --git a/app/src/main/res/layout/view_article_tab_layout.xml
b/app/src/main/res/layout/view_article_tab_layout.xml
index d9b46bc..e7a4553 100644
--- a/app/src/main/res/layout/view_article_tab_layout.xml
+++ b/app/src/main/res/layout/view_article_tab_layout.xml
@@ -2,21 +2,26 @@
<android.support.design.widget.TabItem
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:icon="@drawable/ic_bookmark_border_white_24dp"/>
+ android:icon="@drawable/ic_bookmark_border_white_24dp"
+ android:contentDescription="@string/article_menu_bar_bookmark" />
<android.support.design.widget.TabItem
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:icon="@drawable/ic_share_white_24dp"/>
+ android:icon="@drawable/ic_share_white_24dp"
+ android:contentDescription="@string/article_menu_bar_share" />
<android.support.design.widget.TabItem
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:icon="@drawable/ic_translate_white_24dp"/>
+ android:icon="@drawable/ic_translate_white_24dp"
+ android:contentDescription="@string/menu_page_other_languages" />
<android.support.design.widget.TabItem
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:icon="@drawable/ic_find_in_page" />
+ android:icon="@drawable/ic_find_in_page"
+ android:contentDescription="@string/menu_page_find_in_page" />
<android.support.design.widget.TabItem
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:icon="@drawable/ic_list_white_24dp" />
+ android:icon="@drawable/ic_list_white_24dp"
+ android:contentDescription="@string/menu_show_toc" />
</merge>
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/317010
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7134bca2899db517765b533ea6deb4e185166ad
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
