jenkins-bot has submitted this change and it was merged. Change subject: Fix abuse filter test ......................................................................
Fix abuse filter test testAbuseFilterTriggerStopOnArbitraryErrorCode() tests for arbitrary error codes which are interpreted as TYPE_ERROR. This tests seems to have been mistakenly written to check against TYPE_WARNING. Change-Id: I2d60a0215c742052fd20ca032318217fd9e3fb25 --- M app/src/androidTest/java/org/wikipedia/test/EditTaskTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mholloway: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/androidTest/java/org/wikipedia/test/EditTaskTest.java b/app/src/androidTest/java/org/wikipedia/test/EditTaskTest.java index 436e69d..960e272 100644 --- a/app/src/androidTest/java/org/wikipedia/test/EditTaskTest.java +++ b/app/src/androidTest/java/org/wikipedia/test/EditTaskTest.java @@ -7,8 +7,8 @@ import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; -import org.wikipedia.dataclient.WikiSite; import org.wikipedia.WikipediaApp; +import org.wikipedia.dataclient.WikiSite; import org.wikipedia.editing.AbuseFilterEditResult; import org.wikipedia.editing.CaptchaResult; import org.wikipedia.editing.EditTask; @@ -115,7 +115,7 @@ EditingResult result = Subject.execute(title, wikitext); assertThat(result, instanceOf(AbuseFilterEditResult.class)); - assertThat(((AbuseFilterEditResult) result).getType(), is(AbuseFilterEditResult.TYPE_WARNING)); + assertThat(((AbuseFilterEditResult) result).getType(), is(AbuseFilterEditResult.TYPE_ERROR)); } private void validateCaptcha(EditingResult result) { -- To view, visit https://gerrit.wikimedia.org/r/317065 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d60a0215c742052fd20ca032318217fd9e3fb25 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits