Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317190
Change subject: Don't delete pending data for failed:review
......................................................................
Don't delete pending data for failed:review
'Failed' is correct as far as the front-end goes, but when the
payment is in review, Donor Services might push it through manually.
We should leave donor details unless it's been rejected with finality.
TODO: reuse this logic.
Bug: T148859
Change-Id: If8d251c92603e9f97d5cd54d69f561040677a62a
---
M Core/DataStores/PaymentsInitialDatabase.php
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig
refs/changes/90/317190/1
diff --git a/Core/DataStores/PaymentsInitialDatabase.php
b/Core/DataStores/PaymentsInitialDatabase.php
index dbd33e2..6487d70 100644
--- a/Core/DataStores/PaymentsInitialDatabase.php
+++ b/Core/DataStores/PaymentsInitialDatabase.php
@@ -10,7 +10,7 @@
/**
* Return true if the message already exists in the payments-init table,
- * and is marked as having failed.
+ * and is marked as having failed and been rejected.
*
* @param array $message Payments initial message
* FIXME: Or pass ID parameters explicitly and call this
@@ -23,7 +23,10 @@
if ( $message === null ) {
return false;
}
- if ( $message['payments_final_status'] === 'failed' ) {
+ if (
+ $message['payments_final_status'] === 'failed' &&
+ $message['validation_action'] === 'reject'
+ ) {
return true;
}
return false;
--
To view, visit https://gerrit.wikimedia.org/r/317190
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8d251c92603e9f97d5cd54d69f561040677a62a
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
