Yaron Koren has submitted this change and it was merged.
Change subject: Fix for certain characters in Special:Drilldown search string
......................................................................
Fix for certain characters in Special:Drilldown search string
Change-Id: I6355eb51b930457f46f36dc752b25141c598fd9c
---
M drilldown/CargoSpecialDrilldown.php
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Yaron Koren: Looks good to me, approved
jenkins-bot: Verified
diff --git a/drilldown/CargoSpecialDrilldown.php
b/drilldown/CargoSpecialDrilldown.php
index 3cc9834..f93b24b 100644
--- a/drilldown/CargoSpecialDrilldown.php
+++ b/drilldown/CargoSpecialDrilldown.php
@@ -213,7 +213,7 @@
if ( $searchTerm != null ) {
$url .= ( strpos( $url, '?' ) ) ? '&' : '?';
- $url .= '_search=' . urlencode( str_replace( ' ', '_',
$searchTerm ) );
+ $url .= '_search=' . urlencode( $searchTerm );
}
foreach ( $applied_filters as $af ) {
@@ -748,6 +748,10 @@
$inputName = "_search_$filter_name";
}
+ if ( $cur_value != null ) {
+ $cur_value = htmlentities( $cur_value );
+ }
+
$text = <<< END
<form method="get">
--
To view, visit https://gerrit.wikimedia.org/r/317276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6355eb51b930457f46f36dc752b25141c598fd9c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
