jenkins-bot has submitted this change and it was merged. Change subject: Fix browser tests ......................................................................
Fix browser tests The Hovercards checkbox on the beta preferences page doesn't have an ID anymore. It has a name though, which is used from now on. The regression was introduced in I8636f32330e23814ba3b4c0f5e22e55aaf77883e. Bug: T148856 Change-Id: I7baa78b0d8c560ee29c3a550628bfd47cad1c30e --- M tests/browser/features/support/pages/special_preferences_page.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/support/pages/special_preferences_page.rb b/tests/browser/features/support/pages/special_preferences_page.rb index cff4fa5..7156e74 100644 --- a/tests/browser/features/support/pages/special_preferences_page.rb +++ b/tests/browser/features/support/pages/special_preferences_page.rb @@ -3,7 +3,7 @@ page_url 'Special:Preferences' a(:beta_features_tab, css: '#preftab-betafeatures') - text_field(:hovercards_checkbox, css: '#mw-input-wppopups') + text_field(:hovercards_checkbox, css: '[name=wppopups]') button(:submit_button, css: '#prefcontrol') div(:notification, css: ".mw-notification") -- To view, visit https://gerrit.wikimedia.org/r/317551 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7baa78b0d8c560ee29c3a550628bfd47cad1c30e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
