jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: remove unused colors and dimens
......................................................................
Hygiene: remove unused colors and dimens
Change-Id: Ib34a23cf9f8cb2ab974ef4cfd8b3aaf3a8b1df63
---
M app/src/main/res/values/colors.xml
M app/src/main/res/values/dimens.xml
2 files changed, 0 insertions(+), 11 deletions(-)
Approvals:
Mholloway: Looks good to me, but someone else must approve
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/res/values/colors.xml
b/app/src/main/res/values/colors.xml
index 32f9456..7072a2b 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -42,9 +42,7 @@
<color name="lead_gradient_start">#b8000000</color>
<color name="new_lead_gradient_start">#50000000</color>
<color name="main_toolbar_background">@color/actionbar_background</color>
- <color
name="status_bar_background">@color/primary_dark_material_dark</color>
- <color name="button_light">#777</color>
<color name="window_background_light">#fff</color>
<color name="page_background_light">#fff</color>
<color name="search_background_light">#fff</color>
@@ -62,7 +60,6 @@
<color name="link_preview_text_light">#505050</color>
<color name="link_preview_button_background_light">#eaf0f0f0</color>
<color
name="link_preview_button_background_light_highlight">#eac0c0c0</color>
- <color name="nav_background_light">#f0f0f0</color>
<color name="nav_text_light">#303030</color>
<color name="list_item_text_primary_light">#333</color>
<color name="list_item_text_secondary_light">#777</color>
@@ -84,7 +81,6 @@
<color name="link_preview_text_dark">#d0d0d0</color>
<color name="link_preview_button_background_dark">#ea303030</color>
<color
name="link_preview_button_background_dark_highlight">#ea505050</color>
- <color name="nav_background_dark">#303030</color>
<color name="nav_text_dark">#d0d0d0</color>
<color name="list_item_text_primary_dark">#d0d0d0</color>
<color name="list_item_text_secondary_dark">#808080</color>
diff --git a/app/src/main/res/values/dimens.xml
b/app/src/main/res/values/dimens.xml
index a270873..177baa8 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -1,6 +1,4 @@
<resources>
- <bool name="wide">false</bool>
-
<!-- Default screen margins, per the Android Design guidelines. -->
<dimen name="activity_horizontal_margin">16dp</dimen>
<dimen name="activity_vertical_margin">16dp</dimen>
@@ -36,9 +34,6 @@
<!-- Default screen height ratio for news feature image -->
<item type="dimen" format="float"
name="newsFeatureImageScreenHeightRatio">0.3</item>
-
- <!-- Default font size for Search text -->
- <dimen name="searchTextSize">16sp</dimen>
<dimen name="content_margin">@dimen/activity_horizontal_margin</dimen>
@@ -89,12 +84,10 @@
<item name="crash_report_icon_alpha" format="float" type="dimen">.5</item>
<!-- The Feed -->
- <dimen name="view_feed_header_height">160dp</dimen>
<dimen name="view_feed_padding_top">10dp</dimen>
<dimen name="view_feed_min_column_width">320dp</dimen>
<dimen name="view_list_card_margin_vertical">5dp</dimen>
<dimen name="view_list_card_margin_horizontal">7dp</dimen>
- <dimen name="view_list_card_item_margin">16dp</dimen>
<dimen
name="view_horizontal_scrolling_list_card_item_margin_horizontal">4dp</dimen>
<dimen
name="view_horizontal_scrolling_list_card_item_margin_vertical">0dp</dimen>
<dimen name="view_list_card_item_image">40dp</dimen>
--
To view, visit https://gerrit.wikimedia.org/r/316999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib34a23cf9f8cb2ab974ef4cfd8b3aaf3a8b1df63
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
