Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/318305
Change subject: Avoid endless recursion when environments.yml is missing
......................................................................
Avoid endless recursion when environments.yml is missing
File.dirname('.') is returning '.' and thus causing
endless recursion in search_for_configuration if
environments.yml is missing.
Bug: T149311
Change-Id: Id032ff33aaeeb827c51948b6813087adbd1353a7
---
M lib/mediawiki_selenium/environment.rb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium
refs/changes/05/318305/1
diff --git a/lib/mediawiki_selenium/environment.rb
b/lib/mediawiki_selenium/environment.rb
index efaaf87..fab29f6 100644
--- a/lib/mediawiki_selenium/environment.rb
+++ b/lib/mediawiki_selenium/environment.rb
@@ -108,7 +108,7 @@
# @return [String] Qualified path to the configuration file
#
def search_for_configuration(path)
- return default_configuration if path.nil? || path.empty?
+ return default_configuration if path.nil? || path.empty? || path == '.'
file_path = File.join(path, default_configuration)
return file_path if File.exist?(file_path)
--
To view, visit https://gerrit.wikimedia.org/r/318305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id032ff33aaeeb827c51948b6813087adbd1353a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
