Dzahn has submitted this change and it was merged.
Change subject: mgmt: add missing # in changepw script and some spaces
......................................................................
mgmt: add missing # in changepw script and some spaces
Change-Id: I53f91162fc55896247f4dc7c0f872ed5829f4d60
---
M modules/mgmt/files/changepw
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/mgmt/files/changepw b/modules/mgmt/files/changepw
index 2a4c315..66a1cc1 100644
--- a/modules/mgmt/files/changepw
+++ b/modules/mgmt/files/changepw
@@ -1,7 +1,7 @@
-!/bin/bash
+#!/bin/bash
# change the password of a DRAC mgmt interface
# (c) Papaul Tshibamba, Wikimedia Foundation Inc. 2016
-#sshpass needs to be installed on the host from where this script will run
+# sshpass needs to be installed on the host from where this script will run
echo -n "Enter iDRAC root password (password will not be displayed):"
read -s DRACPASS
echo
@@ -9,11 +9,11 @@
read -s DRAC_NEW_PASS
echo
-#Host ip list file location
+# Host ip list file location
host_list=ip_list.txt
-#Dell Racadm command
-#sshpass -p "$DRACPASS" ssh -o StrictHostKeyChecking=no root@$host_ip racadm
config -g cfgUserAdmin -o cfgUserAdminPassword -i 2 "$DRAC_NEW_PASS"
-#Logfile to keep the logs of the execution
+# Dell Racadm command
+# sshpass -p "$DRACPASS" ssh -o StrictHostKeyChecking=no root@$host_ip racadm
config -g cfgUserAdmin -o cfgUserAdminPassword -i 2 "$DRAC_NEW_PASS"
+# Logfile to keep the logs of the execution
logfile=config.log
#get a list of IPs for the servers
@@ -21,11 +21,11 @@
cat $host_list
}
- #check if the file with the hosts IPs exist
+ # check if the file with the hosts IPs exists
if [ ! -r $host_list ]; then
echo "IP address file $host_list not found or cannot be read"
exit
- #Make a log file. The logfile gets overwritten at each exection
+ # Make a log file. The logfile gets overwritten at each execution
else echo "Starting Bash configuration of Dell Drac for file
$host_list" >$logfile
fi
--
To view, visit https://gerrit.wikimedia.org/r/318652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53f91162fc55896247f4dc7c0f872ed5829f4d60
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Papaul <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
