jenkins-bot has submitted this change and it was merged.
Change subject: Fix ve.test.utils.createSurfaceFromHtml
......................................................................
Fix ve.test.utils.createSurfaceFromHtml
Was passing an HTMLDocument instead of a DM document.
This wasn't failing because the UI surface constructor accepts
HTMLDocuments.
Change-Id: Ibb9a32de4d86295dddc5a677c180ea9c706a1983
---
M tests/ve.test.utils.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tchanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/ve.test.utils.js b/tests/ve.test.utils.js
index 4812066..0a5006c 100644
--- a/tests/ve.test.utils.js
+++ b/tests/ve.test.utils.js
@@ -243,7 +243,9 @@
* @return {ve.ui.Surface} UI surface
*/
ve.test.utils.createSurfaceFromHtml = function ( html ) {
- return this.createSurfaceFromDocument(
ve.createDocumentFromHtml( html ) );
+ return this.createSurfaceFromDocument(
+ ve.dm.converter.getModelFromDom(
ve.createDocumentFromHtml( html ) )
+ );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/318653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb9a32de4d86295dddc5a677c180ea9c706a1983
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Tchanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
