jenkins-bot has submitted this change and it was merged.

Change subject: Add some debug logging to queue consumer
......................................................................


Add some debug logging to queue consumer

Should it log the whole message too?

Change-Id: I15d19520308a4288409e94623a498385d7322c50
---
M Core/QueueConsumers/BaseQueueConsumer.php
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Core/QueueConsumers/BaseQueueConsumer.php 
b/Core/QueueConsumers/BaseQueueConsumer.php
index 2bb458c..5367c51 100644
--- a/Core/QueueConsumers/BaseQueueConsumer.php
+++ b/Core/QueueConsumers/BaseQueueConsumer.php
@@ -101,6 +101,10 @@
                        }
                        $timeOk = $this->timeLimit === 0 || time() <= 
$startTime + $this->timeLimit;
                        $countOk = $this->messageLimit === 0 || $processed < 
$this->messageLimit;
+                       $debugMessage = 'Data is ' . ( $data === null ? '' : 
'not ' ) . 'null, ' .
+                               "time limit ($this->timeLimit) is " . ( $timeOk 
? 'not ' : '' ) . 'elapsed, ' .
+                               "message limit ($this->messageLimit) is " . ( 
$countOk ? 'not ' : '' ) . 'reached.';
+                       Logger::debug( $debugMessage );
                }
                while( $timeOk && $countOk && $data !== null );
                return $processed;
@@ -180,6 +184,7 @@
        public static function getQueue( $queueName ) {
                $config = Context::get()->getConfiguration();
                $key = "data-store/$queueName";
+               Logger::debug( "Getting queue $queueName from key $key" );
 
                // Get a reference to the config node so we can mess with it
                $node =& $config->val( $key, true );
@@ -187,6 +192,7 @@
                        empty( $node['constructor-parameters'] ) ||
                        empty( $node['constructor-parameters'][0]['queue'] )
                ) {
+                       Logger::debug( "'queue' not set, defaulting to 
$queueName" );
                        $node['constructor-parameters'][0]['queue'] = 
$queueName;
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/314613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I15d19520308a4288409e94623a498385d7322c50
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to