Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/319269

Change subject: Allow banner history IDs less than 16 digits long
......................................................................

Allow banner history IDs less than 16 digits long

Oops, we've been rejecting some valid banner history entries.

Change-Id: Ic4fc195e7bbe92130f143d537aaf5eb8a9e3b748
---
M sites/all/modules/queue2civicrm/banner_history/BannerHistoryQueueConsumer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/69/319269/1

diff --git 
a/sites/all/modules/queue2civicrm/banner_history/BannerHistoryQueueConsumer.php 
b/sites/all/modules/queue2civicrm/banner_history/BannerHistoryQueueConsumer.php
index f0957b9..657018a 100644
--- 
a/sites/all/modules/queue2civicrm/banner_history/BannerHistoryQueueConsumer.php
+++ 
b/sites/all/modules/queue2civicrm/banner_history/BannerHistoryQueueConsumer.php
@@ -34,7 +34,7 @@
 
                if (
                        !is_numeric( $contributionTrackingId ) ||
-                       !preg_match( '/^[0-9a-f]{16,20}$/', $bannerHistoryId )
+                       !preg_match( '/^[0-9a-f]{10,20}$/', $bannerHistoryId )
                ) {
                        throw new WmfException(
                                'BANNER_HISTORY',

-- 
To view, visit https://gerrit.wikimedia.org/r/319269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4fc195e7bbe92130f143d537aaf5eb8a9e3b748
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to