Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319316
Change subject: Use 'super' for parent methods, fix documentation
......................................................................
Use 'super' for parent methods, fix documentation
Change-Id: Ifc0ac0a59522f42295f839b6d56d25594f2e1c20
---
M modules/ve.ui.CiteFromIdInspectorTool.js
M modules/ve.ui.CitoidAction.js
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Citoid
refs/changes/16/319316/1
diff --git a/modules/ve.ui.CiteFromIdInspectorTool.js
b/modules/ve.ui.CiteFromIdInspectorTool.js
index 764b9f2..fa60c7b 100644
--- a/modules/ve.ui.CiteFromIdInspectorTool.js
+++ b/modules/ve.ui.CiteFromIdInspectorTool.js
@@ -4,12 +4,16 @@
* @class
* @abstract
* @extends ve.ui.FragmentInspectorTool
+ * @mixins ve.ui.MWEducationPopupTool
* @constructor
* @param {OO.ui.ToolGroup} toolGroup
* @param {Object} [config] Configuration options
*/
ve.ui.CiteFromIdInspectorTool = function VeUiCiteFromIdInspectorTool() {
+ // Parent constructor
ve.ui.CiteFromIdInspectorTool.super.apply( this, arguments );
+
+ // Mixin constructor
ve.ui.MWEducationPopupTool.call( this, {
title: ve.msg(
'cite-ve-dialogbutton-citation-educationpopup-title' ),
text: ve.msg(
'cite-ve-dialogbutton-citation-educationpopup-text' )
@@ -19,6 +23,7 @@
/* Inheritance */
OO.inheritClass( ve.ui.CiteFromIdInspectorTool, ve.ui.FragmentInspectorTool );
+
OO.mixinClass( ve.ui.CiteFromIdInspectorTool, ve.ui.MWEducationPopupTool );
/* Static properties */
diff --git a/modules/ve.ui.CitoidAction.js b/modules/ve.ui.CitoidAction.js
index 2d30ba2..618213d 100644
--- a/modules/ve.ui.CitoidAction.js
+++ b/modules/ve.ui.CitoidAction.js
@@ -15,9 +15,9 @@
* @constructor
* @param {ve.ui.Surface} surface Surface to act on
*/
-ve.ui.CitoidAction = function VeUiCitoidAction( surface ) {
+ve.ui.CitoidAction = function VeUiCitoidAction() {
// Parent constructor
- ve.ui.Action.call( this, surface );
+ ve.ui.CitoidAction.super.apply( this, arguments );
};
/* Inheritance */
--
To view, visit https://gerrit.wikimedia.org/r/319316
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc0ac0a59522f42295f839b6d56d25594f2e1c20
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
