jenkins-bot has submitted this change and it was merged.
Change subject: Ensure max size in not enforced for vectors
......................................................................
Ensure max size in not enforced for vectors
Otherwise they can't be scaled up. Also move svgMaxSize code
to comment as it isn't used yet.
Change-Id: I7af2bc91524e832555b66f090a671672cd14f294
---
M modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
index 4e05556..3010986 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
@@ -29,8 +29,6 @@
// Use 'bitmap' as default media type until we can
// fetch the actual media type from the API
this.mediaType = 'BITMAP';
- // Get wiki defaults
- this.svgMaxSize = mw.config.get( 'wgVisualEditorConfig' ).svgMaxSize;
// Initialize
this.constructor.static.syncScalableToType(
@@ -155,9 +153,13 @@
} else {
scalable.setEnforcedMax( false );
}
+ } else {
+ // EnforcedMax may have previously been set to true
+ scalable.setEnforcedMax( false );
}
// TODO: Some day, when svgMaxSize works properly in MediaWiki
- // we can add it back as max dimension consideration.
+ // we can add it back as max dimension consideration:
+ // mw.config.get( 'wgVisualEditorConfig' ).svgMaxSize
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/319369
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7af2bc91524e832555b66f090a671672cd14f294
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
