jenkins-bot has submitted this change and it was merged.
Change subject: Use 'super' to call parent methods
......................................................................
Use 'super' to call parent methods
Change-Id: Iba051a1e84b2ea805d0b3795933587c735ec0d88
---
M modules/ve-cite/ve.ce.MWReferenceNode.js
M modules/ve-cite/ve.ce.MWReferencesListNode.js
M modules/ve-cite/ve.dm.MWReferenceNode.js
M modules/ve-cite/ve.dm.MWReferencesListNode.js
M modules/ve-cite/ve.ui.MWCitationAction.js
M modules/ve-cite/ve.ui.MWReference.init.js
M modules/ve-cite/ve.ui.MWReferenceGroupInputWidget.js
M modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
8 files changed, 20 insertions(+), 19 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-cite/ve.ce.MWReferenceNode.js
b/modules/ve-cite/ve.ce.MWReferenceNode.js
index d90f457..a5a27e2 100644
--- a/modules/ve-cite/ve.ce.MWReferenceNode.js
+++ b/modules/ve-cite/ve.ce.MWReferenceNode.js
@@ -16,9 +16,9 @@
* @param {ve.dm.MWReferenceNode} model Model to observe
* @param {Object} [config] Configuration options
*/
-ve.ce.MWReferenceNode = function VeCeMWReferenceNode( model, config ) {
+ve.ce.MWReferenceNode = function VeCeMWReferenceNode() {
// Parent constructor
- ve.ce.LeafNode.call( this, model, config );
+ ve.ce.MWReferenceNode.super.apply( this, arguments );
// Mixin constructors
ve.ce.FocusableNode.call( this );
diff --git a/modules/ve-cite/ve.ce.MWReferencesListNode.js
b/modules/ve-cite/ve.ce.MWReferencesListNode.js
index c77c587..f44d9e5 100644
--- a/modules/ve-cite/ve.ce.MWReferencesListNode.js
+++ b/modules/ve-cite/ve.ce.MWReferencesListNode.js
@@ -16,9 +16,9 @@
* @param {ve.dm.MWReferencesListNode} model Model to observe
* @param {Object} [config] Configuration options
*/
-ve.ce.MWReferencesListNode = function VeCeMWReferencesListNode( model, config
) {
+ve.ce.MWReferencesListNode = function VeCeMWReferencesListNode() {
// Parent constructor
- ve.ce.LeafNode.call( this, model, config );
+ ve.ce.MWReferencesListNode.super.apply( this, arguments );
// Mixin constructors
ve.ce.FocusableNode.call( this );
@@ -78,7 +78,7 @@
this.listNode.connect( this, { update: 'onListNodeUpdate' } );
// Parent method
- ve.ce.LeafNode.prototype.onSetup.call( this );
+ ve.ce.MWReferencesListNode.super.prototype.onSetup.call( this );
};
/**
@@ -94,7 +94,7 @@
this.listNode = null;
// Parent method
- ve.ce.LeafNode.prototype.onTeardown.call( this );
+ ve.ce.MWReferencesListNode.super.prototype.onTeardown.call( this );
};
/**
diff --git a/modules/ve-cite/ve.dm.MWReferenceNode.js
b/modules/ve-cite/ve.dm.MWReferenceNode.js
index fdbab27..dc06dfe 100644
--- a/modules/ve-cite/ve.dm.MWReferenceNode.js
+++ b/modules/ve-cite/ve.dm.MWReferenceNode.js
@@ -17,7 +17,7 @@
*/
ve.dm.MWReferenceNode = function VeDmMWReferenceNode() {
// Parent constructor
- ve.dm.LeafNode.apply( this, arguments );
+ ve.dm.MWReferenceNode.super.apply( this, arguments );
// Mixin constructors
ve.dm.FocusableNode.call( this );
diff --git a/modules/ve-cite/ve.dm.MWReferencesListNode.js
b/modules/ve-cite/ve.dm.MWReferencesListNode.js
index 67687f4..b1d3695 100644
--- a/modules/ve-cite/ve.dm.MWReferencesListNode.js
+++ b/modules/ve-cite/ve.dm.MWReferencesListNode.js
@@ -18,7 +18,7 @@
*/
ve.dm.MWReferencesListNode = function VeDmMWReferencesListNode() {
// Parent constructor
- ve.dm.BranchNode.apply( this, arguments );
+ ve.dm.MWReferencesListNode.super.apply( this, arguments );
// Mixin constructors
ve.dm.FocusableNode.call( this );
diff --git a/modules/ve-cite/ve.ui.MWCitationAction.js
b/modules/ve-cite/ve.ui.MWCitationAction.js
index 94586a0..40a6bfb 100644
--- a/modules/ve-cite/ve.ui.MWCitationAction.js
+++ b/modules/ve-cite/ve.ui.MWCitationAction.js
@@ -14,9 +14,9 @@
* @constructor
* @param {ve.ui.Surface} surface Surface to act on
*/
-ve.ui.MWCitationAction = function VeUiMWCitationAction( surface ) {
+ve.ui.MWCitationAction = function VeUiMWCitationAction() {
// Parent constructor
- ve.ui.Action.call( this, surface );
+ ve.ui.MWCitationAction.super.apply( this, arguments );
};
/* Inheritance */
diff --git a/modules/ve-cite/ve.ui.MWReference.init.js
b/modules/ve-cite/ve.ui.MWReference.init.js
index aec2cd4..5b0a6cf 100644
--- a/modules/ve-cite/ve.ui.MWReference.init.js
+++ b/modules/ve-cite/ve.ui.MWReference.init.js
@@ -104,8 +104,8 @@
// Generate citation tool
name = 'cite-' + item.name;
if ( !ve.ui.toolFactory.lookup( name ) ) {
- tool = function
GeneratedMWCitationDialogTool( toolbar, config ) {
-
ve.ui.MWCitationDialogTool.call( this, toolbar, config );
+ tool = function
GeneratedMWCitationDialogTool() {
+
ve.ui.MWCitationDialogTool.apply( this, arguments );
};
OO.inheritClass( tool,
ve.ui.MWCitationDialogTool );
tool.static.group = 'cite';
@@ -131,8 +131,9 @@
// Generate citation context item
if ( !ve.ui.contextItemFactory.lookup( name ) )
{
- contextItem = function
GeneratedMWCitationContextItem( toolbar, config ) {
-
ve.ui.MWCitationContextItem.call( this, toolbar, config );
+ contextItem = function
GeneratedMWCitationContextItem() {
+ // Parent constructor
+
ve.ui.MWCitationContextItem.apply( this, arguments );
};
OO.inheritClass( contextItem,
ve.ui.MWCitationContextItem );
contextItem.static.name = name;
@@ -145,8 +146,8 @@
// Generate dialog
if ( !ve.ui.windowFactory.lookup( name ) ) {
- dialog = function
GeneratedMWCitationDialog( config ) {
- ve.ui.MWCitationDialog.call(
this, config );
+ dialog = function
GeneratedMWCitationDialog() {
+ ve.ui.MWCitationDialog.apply(
this, arguments );
};
OO.inheritClass( dialog,
ve.ui.MWCitationDialog );
dialog.static.name = name;
diff --git a/modules/ve-cite/ve.ui.MWReferenceGroupInputWidget.js
b/modules/ve-cite/ve.ui.MWReferenceGroupInputWidget.js
index dbb8351..5ad9a66 100644
--- a/modules/ve-cite/ve.ui.MWReferenceGroupInputWidget.js
+++ b/modules/ve-cite/ve.ui.MWReferenceGroupInputWidget.js
@@ -21,7 +21,7 @@
this.emptyGroupName = config.emptyGroupName;
// Parent constructor
- OO.ui.ComboBoxWidget.call( this, $.extend( true, { input: {
placeholder: config.emptyGroupName } }, config ) );
+ ve.ui.MWReferenceGroupInputWidget.super.call( this, $.extend( true, {
input: { placeholder: config.emptyGroupName } }, config ) );
this.$element.addClass( 've-ui-mwReferenceGroupInputWidget' );
};
diff --git a/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
b/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
index da5f5b0..186dbe3 100644
--- a/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
+++ b/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
@@ -21,7 +21,7 @@
}, config );
// Parent constructor
- OO.ui.SearchWidget.call( this, config );
+ ve.ui.MWReferenceSearchWidget.super.call( this, config );
// Properties
this.index = [];
@@ -46,7 +46,7 @@
*/
ve.ui.MWReferenceSearchWidget.prototype.onQueryChange = function () {
// Parent method
- OO.ui.SearchWidget.prototype.onQueryChange.call( this );
+ ve.ui.MWReferenceSearchWidget.super.prototype.onQueryChange.call( this
);
// Populate
this.addResults();
--
To view, visit https://gerrit.wikimedia.org/r/319313
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba051a1e84b2ea805d0b3795933587c735ec0d88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
